Skip to content

opgeth-decoupling: migrate direct L2 ethclient call sites in op-e2e #20273

Closed

Description

@sebastianst

Part of #20265 → #20257. See plan §11 and §13. This issue moves op-e2e's direct L2 block/tx/receipt reads off ethclient. The shared helpers they use are in #20272. Follow the sources-client rules in #20265, with #23417 as the worked example:

  • Headers via ethclient are fine.
  • Bodies go through InfoAndUserTxs*, InfoAndDeposits* and InfoAndFirstDeposit*.
  • Receipts go through FetchReceipts/TransactionReceipt, filtered in lockstep by type.

Re-derive the sites with git grep -nE '\.(BlockByNumber|BlockByHash|BlockReceipts)\(' -- op-e2e and classify each by endpoint. L1 sites stay. TransactionByHash on a user tx is fine under upstream.

System and faultproofs tests (can start now, after or with #20272)

Action tests (blocked on the op-reth-test-engine stack, #21787, and #23417)

The stack (#21786/#21787) rewrites actions/helpers/l2_engine.go and edits most of these tests, and #23417 makes L2Engine own one ethclient and one sources.EthClient. Do this part on top of both.

  • Batcher. helpers/l2_batcher.go (ActL2BatchBuffer, and ActAddBlockByNumber) fetches every batched block as a full ethclient block. Every action test that batches goes through it.
  • Users. In helpers/user.go, the CrossLayerUser reads need only headers. LastTxReceipt/CheckReceipt return upstream receipts, and derivation/system_config_test reads OP fields from them.
  • L2Engine. At the stack tip (#21787 @ 4cbd8db), L2Engine.BlockByNumber/GenesisBlock return an *types.Block read through ethclient, and many action tests call them. Once the stack merges, move them to headers or to the partitioned sources accessors.
  • Direct sites: altda, derivation/reorg, proposer, sync and upgrades/{ecotone,fjord,holocene,span_batch}.

rust/kona/tests/proofs (formerly op-e2e/actions/proofs) is out of scope here; it is covered by #23417 and #21905.

Acceptance criteria

  • No op-e2e test fetches L2 block bodies or txs through *ethclient.Client.
  • L2 receipts whose OP fields are read come from sources.
  • Wherever tests pair tx lists with receipt lists, they filter in lockstep. No accessor returns post-exec (0x7D) txs (§11), so tests that count a block's txs on Lagoon+ presets must account for that.

🤖 Co-created with Claude Opus 5.5

Activity

  1. changed the title [-]opgeth-decoupling: migrate 19 direct L2 ethclient call sites in op-e2e[/-] [+]opgeth-decoupling: migrate direct L2 ethclient call sites in op-e2e[/+] on Oct 1, 2026
  2. sebastianst commented on Nov 12, 2026

    @sebastianst
    MemberAuthor

    🤖 Fable says: Done by #23862 (system, faultproofs, L2Engine, user.go, action-test and kona-proof sites) and #23876 (action-test batcher payload path and BlockModifier). The geth-pinned system tests listed above are resolved under #21744.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions