Skip to content

Remove ProtocolVersions contract and its deployment paths #20309

Closed
1 of 1 issue completed
Closed

Description

@sebastianst

Sibling of #20258 under parent #20308. Removes the on-chain ProtocolVersions contract and every deployment / bootstrap path that references it, now that op-node no longer watches it.

Scope

Solidity (packages/contracts-bedrock/)

  • Delete src/L1/ProtocolVersions.sol.
  • Remove references from:
    • scripts/libraries/Types.sol
    • scripts/deploy/DeployImplementations.s.sol
    • scripts/deploy/DeploySuperchain.s.sol
    • scripts/deploy/DeployOPChain.s.sol
    • scripts/deploy/ChainAssertions.sol
    • scripts/deploy/Deploy.s.sol
  • Regenerate/update any snapshot or size-check files that reference the contract.

op-deployer (Go)

Remove ProtocolVersions-related plumbing in:

  • op-deployer/pkg/deployer/pipeline/superchain.go — drop RequiredProtocolVersion, RecommendedProtocolVersion, ProtocolVersionsOwner, ProtocolVersionsProxy, ProtocolVersionsImpl wiring. This also drops the params.OPStackSupport stop-gap carried over from opgeth-decoupling: remove deprecated ProtocolVersions watching from op-node #20258.
  • op-deployer/pkg/deployer/pipeline/implementations.go — drop ProtocolVersionsProxy field.
  • op-deployer/pkg/deployer/bootstrap/superchain.go — drop ProtocolVersionsOwner, RequiredProtocolVersion, RecommendedProtocolVersion fields, CLI flags, validation.
  • op-deployer/pkg/deployer/bootstrap/implementations.go — drop ProtocolVersionsProxy field, CLI flag, validation.
  • op-deployer/pkg/deployer/forge/encoding.go — drop the reflect.TypeOf(params.ProtocolVersion{}) case in the ABI encoder.
  • Search for any other ProtocolVersion* or protocol-versions* flag/CLI references across op-deployer/.

State / intent types

  • Remove ProtocolVersionsOwner, ProtocolVersionsProxy, ProtocolVersionsImpl from deployer state/intent structs.
  • Update any existing deployer state fixtures / snapshots.

Tests & docs

  • Update/delete any test covering ProtocolVersions deployment.
  • Docs or READMEs mentioning the contract.

Dependencies

Coordination

Solidity / contracts work is typically owned by a different team than the Go services. Confirm scope & timing with contracts-bedrock owners before starting Solidity edits.

🤖 Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions