Skip to content

Remove ProtocolVersions support from kona, op-reth, and remaining Go references #20316

Closed

Description

@sebastianst

Sibling of #20258 and #20309 under parent #20308. Removes the deprecated ProtocolVersions mechanism from the Rust stack (kona, op-reth, op-alloy types), then finishes the Go-side cleanup that was deferred in #20258 for wire compat.

Context

#20258 removed ProtocolVersions watching from op-node but kept rollup.Config.ProtocolVersionsAddress in the rollup-config JSON. The reason: kona's RollupConfig Rust struct had protocol_versions_address: Address as a required field, and op-reth exposes the legacy engine_signalSuperchainV1 RPC. Removing the Go field earlier broke 100+ cross-language proof tests. Once Rust no longer requires the field, we can finish the Go cleanup.

Scope

Rust: op-alloy (type definitions)

  • rust/op-alloy/crates/rpc-types-engine/src/superchain.rs — delete SuperchainSignal, ProtocolVersion, ProtocolVersionFormatV0 (or mark #[deprecated] if downstream consumers outside this monorepo need a transitional window).
  • rust/op-alloy/crates/rpc-types-engine/src/lib.rs — drop exports.
  • rust/op-alloy/crates/provider/src/ext/engine.rs — drop the signal_superchain_v1 provider extension method.

Rust: kona

  • rust/kona/crates/protocol/genesis/src/rollup.rs — remove protocol_versions_address: Address from RollupConfig; remove from arbitrary, Default, and test JSON fixtures (lines ~870, ~973).
  • rust/kona/crates/protocol/genesis/src/chain/config.rs — drop the assignment that copies from superchain.
  • rust/kona/crates/protocol/genesis/src/superchain/{config,chain,chains}.rs — remove ProtocolVersionsAddr field in superchain registry types.
  • rust/kona/crates/protocol/registry/src/superchain.rs — drop the rollup.protocol_versions_address = superchain… wire-up.
  • rust/kona/crates/protocol/registry/src/test_utils/{op_mainnet,op_sepolia,base_mainnet,base_sepolia}.rs — drop the field from per-chain test configs.
  • rust/kona/crates/protocol/registry/etc/configs.json — drop from embedded data (if present).
  • rust/kona/crates/protocol/registry/tests/fixtures/custom/configs.json — drop.
  • rust/kona/crates/node/engine/src/client.rs + test_utils/engine_client.rs — remove the signal_superchain_v1 RPC call from the Engine API client.
  • rust/kona/bin/node/src/metrics/cli_opts.rs — check for any remaining protocol-version metric wiring.
  • rust/kona/docker/recipes/kona-node*/grafana/dashboards/overview.json — remove the protocol-version panels.

Rust: op-reth

  • rust/op-reth/crates/rpc/src/engine.rs — remove OP_STACK_SUPPORT constant, signal_superchain_v1 RPC method on the server trait and impl.

Go (follow-up once the Rust side lands)

Once Rust no longer requires protocol_versions_address in the JSON, finish the cleanup in op-node:

  • rollup.Config.ProtocolVersionsAddress field (delete; doc comment explains this is the last step).
  • op-node/rollup/superchain.go — remove the cfg.ProtocolVersionsAddress = superConfig.ProtocolVersionsAddr registry copy.
  • op-node/chaincfg/chains_test.go — drop the three ProtocolVersionsAddress: common.HexToAddress(...) expected-config lines (restored in opgeth-decoupling: remove deprecated ProtocolVersions watching from op-node #20258 for compat).
  • Rerun go test ./op-node/chaincfg/... to confirm TestGetRollupConfig still matches.

Verification

  • cd rust && cargo build --all --all-targets (or just -f rust/kona/justfile b).
  • Rust unit tests pass: cargo nextest run --workspace in rust/.
  • op-acceptance-tests/tests/interop/proofs* (memory-all-opn-op-geth/op-reth CircleCI jobs) must stay green — these were the tests that broke when we first tried to remove the field.
  • Grep: grep -rn "protocol_versions_address\|SuperchainSignal\|signal_superchain_v1\|OP_STACK_SUPPORT\|ProtocolVersion[^s]" rust/ op-node/ op-service/ op-deployer/ returns nothing meaningful.

Dependencies

Out of scope

🤖 Generated by Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions