Repository navigation
Description
Sibling of #20258 and #20309 under parent #20308. Removes the deprecated ProtocolVersions mechanism from the Rust stack (kona, op-reth, op-alloy types), then finishes the Go-side cleanup that was deferred in #20258 for wire compat.
Context
#20258 removed ProtocolVersions watching from op-node but kept rollup.Config.ProtocolVersionsAddress in the rollup-config JSON. The reason: kona's RollupConfig Rust struct had protocol_versions_address: Address as a required field, and op-reth exposes the legacy engine_signalSuperchainV1 RPC. Removing the Go field earlier broke 100+ cross-language proof tests. Once Rust no longer requires the field, we can finish the Go cleanup.
Scope
Rust: op-alloy (type definitions)
rust/op-alloy/crates/rpc-types-engine/src/superchain.rs— deleteSuperchainSignal,ProtocolVersion,ProtocolVersionFormatV0(or mark#[deprecated]if downstream consumers outside this monorepo need a transitional window).rust/op-alloy/crates/rpc-types-engine/src/lib.rs— drop exports.rust/op-alloy/crates/provider/src/ext/engine.rs— drop thesignal_superchain_v1provider extension method.
Rust: kona
rust/kona/crates/protocol/genesis/src/rollup.rs— removeprotocol_versions_address: AddressfromRollupConfig; remove fromarbitrary,Default, and test JSON fixtures (lines ~870, ~973).rust/kona/crates/protocol/genesis/src/chain/config.rs— drop the assignment that copies from superchain.rust/kona/crates/protocol/genesis/src/superchain/{config,chain,chains}.rs— removeProtocolVersionsAddrfield in superchain registry types.rust/kona/crates/protocol/registry/src/superchain.rs— drop therollup.protocol_versions_address = superchain…wire-up.rust/kona/crates/protocol/registry/src/test_utils/{op_mainnet,op_sepolia,base_mainnet,base_sepolia}.rs— drop the field from per-chain test configs.rust/kona/crates/protocol/registry/etc/configs.json— drop from embedded data (if present).rust/kona/crates/protocol/registry/tests/fixtures/custom/configs.json— drop.rust/kona/crates/node/engine/src/client.rs+test_utils/engine_client.rs— remove thesignal_superchain_v1RPC call from the Engine API client.rust/kona/bin/node/src/metrics/cli_opts.rs— check for any remaining protocol-version metric wiring.rust/kona/docker/recipes/kona-node*/grafana/dashboards/overview.json— remove the protocol-version panels.
Rust: op-reth
rust/op-reth/crates/rpc/src/engine.rs— removeOP_STACK_SUPPORTconstant,signal_superchain_v1RPC method on the server trait and impl.
Go (follow-up once the Rust side lands)
Once Rust no longer requires protocol_versions_address in the JSON, finish the cleanup in op-node:
rollup.Config.ProtocolVersionsAddressfield (delete; doc comment explains this is the last step).op-node/rollup/superchain.go— remove thecfg.ProtocolVersionsAddress = superConfig.ProtocolVersionsAddrregistry copy.op-node/chaincfg/chains_test.go— drop the threeProtocolVersionsAddress: common.HexToAddress(...)expected-config lines (restored in opgeth-decoupling: remove deprecated ProtocolVersions watching from op-node #20258 for compat).- Rerun
go test ./op-node/chaincfg/...to confirmTestGetRollupConfigstill matches.
Verification
cd rust && cargo build --all --all-targets(orjust -f rust/kona/justfile b).- Rust unit tests pass:
cargo nextest run --workspaceinrust/. op-acceptance-tests/tests/interop/proofs*(memory-all-opn-op-geth/op-rethCircleCI jobs) must stay green — these were the tests that broke when we first tried to remove the field.- Grep:
grep -rn "protocol_versions_address\|SuperchainSignal\|signal_superchain_v1\|OP_STACK_SUPPORT\|ProtocolVersion[^s]" rust/ op-node/ op-service/ op-deployer/returns nothing meaningful.
Dependencies
- Follows opgeth-decoupling: remove deprecated ProtocolVersions watching from op-node #20258 (Go watching removal, landed as op-node: remove deprecated ProtocolVersions watching #20311).
- Follows Remove ProtocolVersions contract and its deployment paths #20309 (ProtocolVersions contract/deployment removal) — technically independent but closely related; coordinate landing order so
params.OPStackSupportdoesn't dangle.
Out of scope
- The
ProtocolVersions.solcontract itself and op-deployer's contract-deployment flow — covered by Remove ProtocolVersions contract and its deployment paths #20309.
🤖 Generated by Claude Code
Activity