Skip to content

opgeth-decoupling: swap PostExecTx span-batch sites + remaining one-off fork symbols to op-core #21901

Closed

Description

@sebastianst

Part of #20257; finishes the remaining scope of #20263 (whose sub-issues are all closed). Doc: §1/§2/§15 of opgeth-decoupling.md.

Scope

  1. PostExecTx span-batch swap (the core item): op-node/rollup/derive/{batches,span_batch,span_batch_tx,span_batch_txs}.go still use go-ethereum's types.PostExecTxType and construct &types.PostExecTx{…} (span_batch_tx.go convertToFullTx). Swap to op-core/types (optypes.PostExecTxType, struct-to-bytes via optypes.PostExecTx.MarshalBinary — same pattern op-node/op-service/op-batcher: swap DepositTx + Transaction-method helpers to op-core #21791 used for DepositTx). Wire compatibility is pinned by the existing op-core differential test.
  2. One-off fork symbols (§15 misc category):
    • Transaction.SetBlobTxSidecar (op-service/signer/client.go) — reattach the sidecar without the fork helper.
    • types.LogForStorage (op-chain-ops/crossdomain/legacy.go) — deleted upstream; inline the legacy RLP struct locally.
    • params.InteropCrossL2InboxAddress (op-core/interop/messages/logs.go) — use op-core/predeploys.
    • types.NewIsthmusSigner in test infra (op-service/testutils, op-node/rollup/derive/test) — verify semantic equivalence with an upstream signer before swapping; if not equivalent, add an op-core helper.

Not here: the check-* uses of NewIsthmusSigner (check-derivation, check-ecotone) — re-homed to #21746 with the rest of the check-* swaps.

Acceptance

🤖 Generated by Claude Fable 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions