Skip to content

op-devstack: sysgo hard-codes SupportsPostFinalizationELSync=false while running op-reth #23318

Closed

Description

@sebastianst

sysgo builds the op-node sync config with SupportsPostFinalizationELSync: false, but its default L2 EL is op-reth (singlechain_build.go#L103). A production op-node derives the flag from --l2.enginekind (service.go#L354). Only Geth lacks post-finalization EL sync; Erigon and Reth support it (engine_kind.go#L37-L44).

Consequence: an ELSync op-node under sysgo behaves as if it drove op-geth. When it starts against an EL that already has a non-genesis finalized block, it takes the geth-only "Skipping EL sync and going straight to CL sync because there is a finalized block" branch instead of re-entering EL sync as it would with op-reth in production (engine_controller.go#L788-L798). Sysgo EL-sync and restart tests therefore exercise a code path production op-reth deployments don't take, and the op-reth path goes untested end to end.

Fix direction: derive the flag from the L2 EL kind sysgo actually starts. For example, map the EL kind to an engine.Kind and use Kind.SupportsPostFinalizationELSync(), or set the op-node engine kind directly so the flag follows as it does in service.go.

🤖 Co-created with Claude Opus 5.5

Activity

  1. sebastianst commented on Nov 12, 2026

    @sebastianst
    MemberAuthor

    🤖 Fable says: Sequencing: this lands as its own PR right after the sysgo op-geth L2 EL is removed (#21744, step E). With op-reth as the only EL kind the flag is simply true for op-node, and a separate PR keeps any change in the sysgo EL-sync tests attributable. Draft #23421 plumbs the same flag through L2CLConfig for the mixed runtime only and touches the same line in singlechain_build.go, so the two need coordinating.

  2. self-assigned this
    on Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions