Skip to content

opgeth-decoupling: swap or delete remaining non-test fork-symbol uses #23406

Closed
1 of 1 issue completed

Description

@sebastianst

A few non-test uses of op-geth-only APIs are not tracked by any open issue of the decoupling (#20257). Each blocks the cutover (#20266). The opgeth-ratchet CI check lists them in its allowlist (ops/scripts/opgeth-ratchet/allowlist.txt), with reasons starting #23406.

  • op-service/txinclude — the resubmitter classifies core.ErrTxFilteredOut, op-geth's interop tx-filter rejection, as a permanent failure. Upstream has no such error. Classify op-reth's equivalent rejection instead (the interop load test's match follows).
  • op-node — NewL1ChainConfig exempts an L1 that is itself an OP chain (L3 setups) from the blob-schedule check via ChainConfig.IsOptimism(). Upstream has neither the method nor the optimism JSON field, so it needs a different way to recognise an OP L1, or a decision to drop the exemption. Its test builds such an L1 config with params.OptimismConfig and changes with it.
  • op-test-sequencer — the fake-PoS builder calls engine.ExecutableDataToBlockNoHash with the fork's extra block-type argument. It builds L1 blocks, so it drops the argument.
  • op-chain-ops/cmd/receipt-reference-builder — uses the fork's Transaction.EffectiveNonce. The tool collects data for chains with post-Bedrock, pre-Canyon activity and is unused, so op-chain-ops: delete receipt-reference-builder #23410 deleted it (opgeth-decoupling: delete op-chain-ops/cmd/receipt-reference-builder #23408). Done.

Related but tracked elsewhere: op-wheel's geth ChainConfig fork reads (#23217), op-sync-tester's fork config and Block.WithdrawalsRoot (#21525), and test and DSL code (#23405).

🤖 Co-created with Claude Opus 5.5

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions