Skip to content

kona-node: keep delegated finalization pending during EL catch-up #23675

Closed

Description

@joshklop

Delegated derivation can terminate Kona during ordinary execution-client catch-up. This is the catch-up liveness scope of the delegated derivation parity tracker.

Reproduction

  1. Local unsafe=20, safe=10, finalized=0; delegate reports safe=30, finalized=15.
  2. Consolidation requests the new forkchoice; the EL returns SYNCING.
  3. FinalizeTask fetches finalized block 15 by hash. The local EL has not downloaded it yet and returns null.
  4. BlockNotFound is classified Critical and propagates out of the engine actor, stopping the node.

An honest upstream can trigger this. It was reproduced with actual kona-engine tasks and mocked Engine API responses, not a live EL outage.

Source: finalized lookup, critical classification.

Acceptance criteria

  • Missing finalized data while the EL catches up does not terminate Kona or create a tight retry loop.
  • The target remains pending or is retried through the existing polling/task mechanism, and finalizes once its block becomes available.
  • Preserve hash-pinned lookup and block identity/height validation; never substitute the local block at the same number.
  • Cover missing-then-present recovery and ensure malformed/inconsistent finalized identities still fail safely.
  • Keep this PR independent of forkchoice retry bookkeeping and finalized monotonicity fixes.

Confirmed on deployed 49efa52 and PR #23627 tip 2763f5e; relevant code is unchanged on develop cfec650e57.

Parent tracker: https://github.com/ethereum-optimism/protocol-team/issues/545 (target November 5, 2026).

Activity

  1. einar-oplabs commented on Nov 4, 2026

    @einar-oplabs
    Contributor

    Draft fix: #23908. It follows up on the closed #23678 with a fresh implementation. A pinned finalized target that the EL has not downloaded yet, or that sits above the local safe head, is skipped without a forkchoice update and resubmitted by the next delegate poll, so the node no longer stops during catch-up. Pinned lookups now reject a returned block whose hash or number differs (BlockIdentityMismatch), and by-number finalization still fails hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-konaArea: konaC-bugCategory: bugs

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions