Skip to content

kona-node: prevent delegated finalized-head regression #23677

Closed

Description

@joshklop

A stale delegated source can make Kona request a backward finalized-head update. This is the finalized-monotonicity scope of the delegated derivation parity tracker.

Reproduction

With local unsafe=30, safe=20, finalized=10, a delegate reports an existing finalized block 5. FinalizeTask checks only that the target is no higher than safe, sends an FCU with finalized=5, and records finalized=5 if EL returns VALID.

The actual Kona engine unit test proves the backward request and acceptance logic. It does not establish that real op-reth accepts a finalized regression. EL rejection could instead cause recovery errors.

Compare Kona finalization with op-node's external finalized monotonicity guard.

Acceptance criteria

  • Older finalized references do not emit backward FCUs or regress CL finalized state.
  • Repeated identical finalized references remain harmless while allowing legitimate pending EL synchronization.
  • Conflicting hashes at the current finalized height are rejected safely rather than silently replacing finality.
  • Preserve hash-pinned lookup, height validation, and safe/finalized ordering checks.
  • Cover older, identical, conflicting-same-height, and legitimate advancing targets.
  • Keep the implementation independent of catch-up liveness and forkchoice delivery/retry fixes.

Confirmed on deployed 49efa52 and PR #23627 tip 2763f5e; relevant code is unchanged on develop cfec650e57. Implement as an independent PR against develop.

Parent tracker: https://github.com/ethereum-optimism/protocol-team/issues/545 (target November 5, 2026).

Activity

  1. einar-oplabs commented on Nov 3, 2026

    @einar-oplabs
    Contributor

    Draft fix: #23899. It follows up on the closed #23679 with a fresh implementation. Targets below the finalized head are skipped with a warning, and a conflicting hash at the finalized height is skipped with an error while local finality is kept (no halt). The resolved block's height is now checked for by-number lookups too.

  2. einar-oplabs commented on Nov 9, 2026

    @einar-oplabs
    Contributor

    #23899 updated (force-pushed, still one signed commit): the delegate actor now checks statuses against the finalized head the engine applied, read from its published state, instead of the one it last forwarded. Before, a finalized target the engine skipped as not canonical became the baseline, so the delegate's return to the canonical chain (finalized at or below that height) was rejected, safe head included, and safe progress stopped. Found by the #24007 scenarios; regression test poll_accepts_status_after_engine_skipped_forwarded_finality.

  3. einar-oplabs commented on Nov 12, 2026

    @einar-oplabs
    Contributor

    Opus 5.5 (high): Fixed by #23900, merged to develop as b636ba6 (it includes #23899, which was merged into #23900's branch). The PR body listed this issue without a closing keyword, so GitHub did not close it automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-konaArea: konaC-bugCategory: bugs

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions