Skip to content

op-acceptance-tests: run TestELSyncSafeRetractedByOffset against kona-node #23828

Open

Description

@joshklop

Summary

TestELSyncSafeRetractedByOffset is skipped when the acceptance suite runs against kona-node (sysgo.SkipOnKonaNode(t, "kona-node does not support OffsetELSafe"), added in #23827).

The test configures the verifier with OffsetELSafe, which maps to op-node's --syncmode.offset-el-safe. After EL sync completes, op-node holds the safe and finalized heads that far behind the synced tip. The flag defaults to 12h, matching the OP Mainnet sequencing window. kona-node has no equivalent option, and devstack rejects the setting for kona-node with unsupported L2CL option for kona-node (op-devstack/sysgo/l2_cl_kona_config.go).

Until #23827, the test was skipped on op-reth, and op-geth skips every chain that activates Karst. So this gap was never reached in any CI configuration.

Required work

Implement the EL-sync safe/finalized offset in kona-node with the same semantics and default as op-node. Wire it through the devstack kona-node config, then remove the kona-node skip.

Acceptance criteria

  • kona-node supports an EL-sync safe/finalized offset matching op-node's --syncmode.offset-el-safe semantics and default.
  • op-devstack/sysgo/l2_cl_kona_config.go accepts OffsetELSafe for kona-node.
  • The kona-node skip is removed and TestELSyncSafeRetractedByOffset passes against kona-node.
  • Existing op-node coverage continues to pass.

Related

Activity

  1. self-assigned this
    on Nov 2, 2026
  2. added a commit that references this issue on Nov 22, 2026
    05dfb20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions