You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
op-devstack,op-reth: unify the duplicated test seams of the reth v2.6.0 coverage stacks #24010
The two test-coverage stacks for the reth v2.6.0 bump (#23385 proofs-history ExEx, #23386 the rest) were written in parallel and grew near-duplicate devstack and op-reth test seams. Once both stacks are in, these should be unified so op-devstack carries one of each.
Duplicates
Log capture. The proofs stack added RecordLogLines (used by the proofs-history acceptance tests to watch op-reth's output for pruner and engine lines); the non-ExEx stack added RecordLogs with the LogObservable seam on op-devstack/stack/logs.go and op-service/logpipe. One recorder with one interface should serve both.
Workload helpers.newWorkload and the account/contract fixtures that drive a proofs-history follower (rust/op-reth/tests/proofs/core/window_helpers_test.go) and the acceptance packages' own workloads overlap; one shared helper in the proofs e2e utils or in the DSL would do.
After the 24 PRs merge, as one or two upkeep PRs, so the merge order of the stacks does not have to change. Each duplicate is listed with the PR that introduced it so the cleanup can cite them.
Activity