Skip to content

op-devstack,op-reth: unify the duplicated test seams of the reth v2.6.0 coverage stacks #24010

Open

Description

@einar-oplabs

Summary

The two test-coverage stacks for the reth v2.6.0 bump (#23385 proofs-history ExEx, #23386 the rest) were written in parallel and grew near-duplicate devstack and op-reth test seams. Once both stacks are in, these should be unified so op-devstack carries one of each.

Duplicates

  • Log capture. The proofs stack added RecordLogLines (used by the proofs-history acceptance tests to watch op-reth's output for pruner and engine lines); the non-ExEx stack added RecordLogs with the LogObservable seam on op-devstack/stack/logs.go and op-service/logpipe. One recorder with one interface should serve both.
  • Workload helpers. newWorkload and the account/contract fixtures that drive a proofs-history follower (rust/op-reth/tests/proofs/core/window_helpers_test.go) and the acceptance packages' own workloads overlap; one shared helper in the proofs e2e utils or in the DSL would do.
  • Flush cadence types. The ExEx test module has its own copy of the live tests' FlushCadence; a thresholds struct in the trie crate (behind test-utils, or replacing the two positional u64s of EngineHandle::spawn_with_thresholds) would remove it (noted in op-reth: test the proofs sync loop under pruning and the FinishedHeight contract #23449).
  • Store wrappers and snapshots. StoreWithHooks (liveness test), the model test's store wrapper and the live tests' DiskSnapshot each wrap the proofs store for observation; one wrapper with hooks would cover all three (noted in op-reth: model-based test of the proofs engine state machine #23451 and op-reth: liveness test of the proofs engine under a slow store #23455).

When

After the 24 PRs merge, as one or two upkeep PRs, so the merge order of the stacks does not have to change. Each duplicate is listed with the PR that introduced it so the cleanup can cite them.

Related

Activity

  1. self-assigned this
    on Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions