Skip to content

op-deployer: keep an L1 dev genesis prefund for the deployer in a genesis apply #24124

Closed

Description

@nonsense

Problem

In a genesis-target apply, ApplyPipeline runs prefund-l1-dev-genesis before preinstall-l1-dev-genesis (apply.go:380-391). PreinstallL1DevGenesis ends with env.Forge.Genesis.Wipe(env.Deployer) (preinstall_l1_dev_genesis.go:17). So when l1DevGenesisParams.prefund has an entry for the deployer, the prefund stage sets that balance and the preinstall stage deletes it. The L1 dev genesis has no balance for the deployer, and op-deployer gives no error or warning.

ApplyL1DevGenesis runs the preinstall stage first and the prefund stage last (apply.go:211-213), so it keeps the entry.

This predates the forge port.

Proposal

In ApplyPipeline, run preinstall-l1-dev-genesis before prefund-l1-dev-genesis. The wipe still comes after all deployments, so the deployer's nonce in the genesis does not change. Only an explicit prefund entry for the deployer survives.

Done when

  • A genesis apply with an l1DevGenesisParams.prefund entry for the deployer gives the deployer that balance in the L1 dev genesis.
  • A test covers it.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions