Skip to content

opgeth-decoupling: prepare the cutover #24172

Closed

Description

@sebastianst

The cutover (#20266) should hold only what needs the go.mod change. This issue collects the work that can land before it.

Why now

The ratchet type-checks the tree against go-ethereum v1.17.2, the version op-geth is based on. The cutover moves to the latest release, v1.17.10. A trial run of the ratchet against each of v1.17.7 to v1.17.10 gives the same result:

  • The "upstream backport" entries of the allowlist are no longer needed.
  • More APIs differ, and the allowlist shows none of them:
    • changed signatures: core.IntrinsicGas, core.FloorDataGas, core.ApplyTransaction, core.ProcessBeaconBlockRoot, core.ProcessParentBlockHash, state.StateDB.Commit, IntermediateRoot and SetTxContext, vm.EVM.Call and Create, node.NewHTTPHandlerStack
    • missing symbols: params.BlobScheduleConfig.Osaka and .Amsterdam, params.DefaultOsakaBlobConfig, core.GasPool.Gas, core.ErrInsufficientBalanceWitness
    • engine.ExecutableData.BlockAccessList is a []byte upstream
  • Production code is affected in op-batcher/batcher, op-service/rpc and op-service/txinclude. The rest is tests and test support.

The tree has also never run its tests against upstream go-ethereum.

Work

  • Make the ratchet type-check against the cutover version, and list the API differences above as cutover edits.
  • Shed the OP fork fields and the Optimism struct from op-core/params.GethChainConfig(). After op-devstack: remove the in-process op-geth L2 EL and the EL-kind selector #24156, GethChainConfig() and GethGenesis() have no caller outside op-core/params and op-core/genesis except tests. This settles the audit item of opgeth-decoupling: final cutover (flip go.mod to upstream go-ethereum) #20266.
  • Pin golden vectors for the values that only the op-geth differential tests pin today, e.g. user deposits with a mint, a value or a contract creation.
  • Delete the op-geth differential tests, as the last PR before the cutover.
  • Stop using a differing API where the code can do without it, e.g. core.ErrInsufficientBalanceWitness.
  • Open the cutover PR as a draft and run CI on it. Move every fix that does not need the go.mod change into a PR of its own.

🤖 Co-created with Claude Fable 5.2

Activity

  1. self-assigned this
    on Nov 16, 2026
  2. sebastianst commented on Nov 18, 2026

    @sebastianst
    MemberAuthor

    🤖 Fable says: Every item has landed. The cutover itself is #24176, tracked in #20266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions