Skip to content

op-reth: test eth_sendRawTransactionConditional, lost with op-e2e/opgeth #24247

Open

Description

@sebastianst

#23864 deleted op-e2e/opgeth/conditional_tx_test.go, which tested eth_sendRawTransactionConditional on op-geth. #24088 and #24193 cover only op_geth_test.go, so this coverage has not come back. op-reth implements the endpoint, but no test exercises it.

Deleted op-geth test Rule op-reth code op-reth tests
TestSendRawTransactionConditionalDisabled Without the flag the method does not exist (-32601) node.rs registers the extension only if enable_tx_conditional only the CLI flag parse
TestSendRawTransactionConditionalEnabled A condition that can no longer hold is rejected; an accepted one is included send_raw_transaction_conditional (cost limit, block and timestamp bounds, validate_known_accounts) none
TestSendRawTransactionConditionalTxForwarding A non-sequencer node forwards the conditional tx to the sequencer, which includes it forward_raw_transaction_conditional sequencer.rs tests check only request serialization

Also untested, and not covered by the op-geth tests either: the txpool maintenance task that evicts conditional transactions whose condition fails at a new block (maintain.rs).

The op-geth tests checked op-geth's error codes, but the rule is the behaviour above. Before choosing between an op-reth node test and an acceptance test, check whether op-reth's error codes match the spec and op-geth (pre-Karst).

🤖 Co-created with Claude Opus 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions