Repository navigation
docs: require a partitioned full-range sweep in reth bump reviews - #23063
Merged
Merged
Conversation
The review guide's lockfile funnel and mirror worklist only surface upstream changes that touch code we already mirror. Changes that matter without an op- counterpart, such as a trait method installed by default, a more lenient decoder, a moved CLI default, or a fix resting on a precondition OP breaks, only show up by reading every upstream commit. Add that sweep to the guide as partitioned parallel agents with per-commit adopt/no-impact verdicts, make the reviewer agent run it, and require it in the update-reth skill. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
joshklop
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reth-bump review guide's lockfile funnel and mirror worklist only surface upstream changes that touch code we already mirror. The items that needed adoption in the v2.5.2 bump (#22495) had no op- counterpart: an
EthApimethod installed by default, the defaultedHandler::tx_gasentry point, a more lenient receipt decoder, moved engine defaults. They were found by partitioned agents reading every upstream commit, which the guide did not ask for.This adds that sweep to
docs/ai/reth-update-review.md(partition each bumped family's range by area, one agent per partition, per-commit adopt or no-impact verdict with a reason, consolidate), makes thereth-update-revieweragent run it by spawning the partition agents, and requires it in theupdate-rethskill. Docs and agent instructions only; no code, so the code review agents do not apply.🤖 Generated with Claude Code