Skip to content

docs: require a partitioned full-range sweep in reth bump reviews - #23063

Merged
sebastianst merged 1 commit into
developfrom
seb/reth-review-partitioned-sweep
Sep 28, 2026
Merged

sebastianst merged 1 commit into
developfrom
seb/reth-review-partitioned-sweep

Conversation

@sebastianst

Copy link
Copy Markdown
Member

The reth-bump review guide's lockfile funnel and mirror worklist only surface upstream changes that touch code we already mirror. The items that needed adoption in the v2.5.2 bump (#22495) had no op- counterpart: an EthApi method installed by default, the defaulted Handler::tx_gas entry point, a more lenient receipt decoder, moved engine defaults. They were found by partitioned agents reading every upstream commit, which the guide did not ask for.

This adds that sweep to docs/ai/reth-update-review.md (partition each bumped family's range by area, one agent per partition, per-commit adopt or no-impact verdict with a reason, consolidate), makes the reth-update-reviewer agent run it by spawning the partition agents, and requires it in the update-reth skill. Docs and agent instructions only; no code, so the code review agents do not apply.

🤖 Generated with Claude Code

The review guide's lockfile funnel and mirror worklist only surface upstream
changes that touch code we already mirror. Changes that matter without an op-
counterpart, such as a trait method installed by default, a more lenient
decoder, a moved CLI default, or a fix resting on a precondition OP breaks, only
show up by reading every upstream commit. Add that sweep to the guide as
partitioned parallel agents with per-commit adopt/no-impact verdicts, make the
reviewer agent run it, and require it in the update-reth skill.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sebastianst
sebastianst requested a review from a team as a code owner September 28, 2026 18:50
@sebastianst
sebastianst added this pull request to the merge queue Sep 28, 2026
Merged via the queue into develop with commit c673314 Sep 28, 2026
49 checks passed
@sebastianst
sebastianst deleted the seb/reth-review-partitioned-sweep branch September 28, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants