Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/ai/reth-update-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,11 @@ a **minor** bump, `op-revm` at `20.x` only by a major.
So: **if the adaptation diff changes a `version =` line in one of our published crates,
say so in the review.** It is a release-coordination item, not just a manifest edit.

The op-reth crates (`op-reth`, `reth-optimism-*`, `reth-op`) and the `op-alloy*` crates
are each versioned as a group (UPDATING-RETH step 4): flag a `version =` change that moves
only part of a family, and check whether sibling crates changed their public API without a
bump.

## Review process

1. Identify the old→new pins from the `Cargo.toml` diff; compute the lockfile
Expand Down
8 changes: 8 additions & 0 deletions rust/UPDATING-RETH.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,14 @@ main's CI actually validated.
one, call it out in the PR description so the downstream pin can move with
it.

When a bump is genuinely needed, **version in-tree crate families as a
group.** Upstream reth versions every crate from one workspace version; two
in-tree families follow the same rule: the published op-reth crates
(`op-reth`, `reth-optimism-*`, `reth-op`) and the `op-alloy*` crates. When
any crate of a family needs a new version, bump the whole family to the
same version. A lone bump leaves siblings whose API also changed at a
version that downstream requirements still accept.

5. Refresh both lockfiles — the main workspace and the SP1 guest programs
workspace each have their own. `cargo update -p reth` does **not** work —
there is no top-level crate literally named `reth` in the dependency graph.
Expand Down
Loading