Repository navigation
docs: sweep upstream fixes after the reth update target - #23132
Merged
sebastianst merged 1 commit intoOct 1, 2026
Merged
sebastianst merged 1 commit into
sebastianst merged 1 commit into
Conversation
A bump freezes us on its target until the next one, so an upstream fix that lands just after the target ships as a known bug. Add a forward sweep to the reth update review: read every upstream commit from the target to the latest, report fixes to defects present at the target with their cherry-pick cleanliness, and recommend cherry-picking them onto the fork pin or retargeting the bump. The reviewer agent runs it and the update-reth skill asks the user to decide before shipping. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
joshklop
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reth bump freezes us on its target until the next bump, so an upstream fix that lands just after the target ships as a known bug. In the v2.6.0 review, upstream had already fixed the overlay storage-root consensus bug and a historical-proof bug after v2.6.0 (reth#27129). We found the first independently and missed the second. A forward sweep would have surfaced both directly.
The reth update review now also sweeps upstream changes newer than the target, every commit, partitioned like the full-range sweep:
--cherry-pick.The
reth-update-revieweragent runs it. Theupdate-rethskill skims it when picking the target, so a retarget usually comes before the adaptation work, and asks for the decision before shipping.This is docs and agent instructions only, so the code review agents don't apply. A doc review's findings are folded in. Stacked on #23120.
🤖 Co-created with Claude Opus 5.5