Skip to content

docs: sweep upstream fixes after the reth update target - #23132

Merged
sebastianst merged 1 commit into
seb/reth-review-persistence-layoutfrom
seb/reth-review-forward-sweep
Oct 1, 2026
Merged

sebastianst merged 1 commit into
seb/reth-review-persistence-layoutfrom
seb/reth-review-forward-sweep

Conversation

@sebastianst

Copy link
Copy Markdown
Member

A reth bump freezes us on its target until the next bump, so an upstream fix that lands just after the target ships as a known bug. In the v2.6.0 review, upstream had already fixed the overlay storage-root consensus bug and a historical-proof bug after v2.6.0 (reth#27129). We found the first independently and missed the second. A forward sweep would have surfaced both directly.

The reth update review now also sweeps upstream changes newer than the target, every commit, partitioned like the full-range sweep:

  • Range: patch-equivalent commits the new pin already carries are excluded via --cherry-pick.
  • What counts: fixes to defects at the new pin in code op-reth runs, including generic subsystems without an op- override.
  • Pickability: each finding is tested for a clean cherry-pick and build onto the fork pin. For revm and alloy, the check is for a semver-compatible patch release.
  • Decision: findings come with a cherry-pick-or-retarget recommendation for the human.

The reth-update-reviewer agent runs it. The update-reth skill skims it when picking the target, so a retarget usually comes before the adaptation work, and asks for the decision before shipping.

This is docs and agent instructions only, so the code review agents don't apply. A doc review's findings are folded in. Stacked on #23120.

🤖 Co-created with Claude Opus 5.5

A bump freezes us on its target until the next one, so an upstream fix
that lands just after the target ships as a known bug. Add a forward
sweep to the reth update review: read every upstream commit from the
target to the latest, report fixes to defects present at the target
with their cherry-pick cleanliness, and recommend cherry-picking them
onto the fork pin or retargeting the bump. The reviewer agent runs it
and the update-reth skill asks the user to decide before shipping.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@sebastianst
sebastianst requested a review from a team as a code owner October 1, 2026 09:01
@sebastianst
sebastianst added this pull request to stack #23133 October 1, 2026 09:16
@sebastianst
sebastianst added this pull request to the merge queue Oct 1, 2026
Merged via the queue into develop with commit b982663 Oct 1, 2026
49 checks passed
@sebastianst
sebastianst deleted the seb/reth-review-forward-sweep branch October 1, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants