Skip to content

op-acceptance-tests,op-devstack,op-service: hold the sequencer to the txpool minimum priority fee on local transactions - #23444

Closed
einar-oplabs wants to merge 1 commit into
einar/23402-eth71-opgeth-peeringfrom
einar/23400-txpool-min-priority-fee
Closed

einar-oplabs wants to merge 1 commit into
einar/23402-eth71-opgeth-peeringfrom
einar/23400-txpool-min-priority-fee

Conversation

@einar-oplabs

@einar-oplabs einar-oplabs commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

reth 2.6 applies --txpool.minimum-priority-fee to local transactions too, which changes what sequencer users see.

An op-reth sequencer running the flag without --txpool.nolocals must refuse a transfer one wei under the minimum through eth_sendRawTransaction and eth_sendRawTransactionConditional, and include one at the minimum. The two txpool flags become OpRethConfig fields, since op-reth rejects a repeated flag.

Stacked on #23443. Closes #23400. Local verification, findings and notes: detail comment.

Breakdown

Added Removed Net
Implementation 176 15 +161
Tests 214 0 +214
Docs 0 0 0

AI Reviews

  • <ISODATETIME> <COMMITID> Fable 5.1 xhigh
  • <ISODATETIME> <COMMITID> GPT-6.1-Sol xhigh
  • <ISODATETIME> <COMMITID> Opus 5.5 xhigh

🤖 Generated with Claude Code

@opgitgovernance

Copy link
Copy Markdown
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Oct 30, 2026
@einar-oplabs einar-oplabs reopened this Nov 6, 2026
@einar-oplabs einar-oplabs removed the S-stale Status: Will be closed unless there is activity label Nov 6, 2026
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch 2 times, most recently from 4f27eb2 to 6e5aef7 Compare November 10, 2026 13:38
@einar-oplabs

Copy link
Copy Markdown
Contributor Author

Claude: Detail moved out of the PR description when the branch was squashed into 6e5aef7. It is the description as it stood before the squash, unedited, so it describes the earlier commits.


reth 2.6 (#23046, reth#26861) applies --txpool.minimum-priority-fee to every transaction origin; reth 2.5.2 on develop exempts transactions submitted over the node's own RPC. On a sequencer nearly every submission is local, so this changes what users see once the bump lands. This PR pins the behaviour with an acceptance test and records whether production sequencers run with the flag.

Stacked on #23443, #23440, #23438, #23436, #23431, #23427, #23421 and #23418.

What the tests cover

Package op-acceptance-tests/tests/op_reth_txpool_minimum_priority_fee: an op-reth sequencer alone, started with --txpool.minimum-priority-fee=1000000000 (1 gwei), reth's local exemptions kept (no --txpool.nolocals, the way production runs) and --rollup.enable-tx-conditional. Every transaction is signed offline with a pinned 100 gwei fee cap, so only the tip decides what the pool does with it.

Test Cell develop (reth 2.5.2) #23046 (reth 2.6)
TestSequencerRejectsATransactionBelowTheMinimumPriorityFee (tip = minimum − 1 wei; requires -32003 transaction priority fee below minimum required priority fee 1000000000 and the sequencer to know nothing of the transaction afterwards) eth_sendRawTransaction skipped, names #23400: the sequencer pools and includes it refused
eth_sendRawTransactionConditional refused refused
TestSequencerIncludesATransactionAtTheMinimumPriorityFee (tip = minimum; requires acceptance and a successful receipt) eth_sendRawTransaction included included
eth_sendRawTransactionConditional included included

Matrix: submission {eth_sendRawTransaction, eth_sendRawTransactionConditional} as table-driven subtests; CL {op-node, kona-node} through DEVSTACK_L2CL_KIND. The accepted value is the threshold itself (reth's check is tip < minimum), which is the tightest passing tip and the case reth#26861's own regression test uses.

Findings

  • The conditional cell needs no skip. The issue text says reth#26861 "extends the minimum to local and conditional transactions", but eth_sendRawTransactionConditional adds to the pool with TransactionOrigin::Private, and TransactionOrigin::is_local() matches only Local in both reth 2.5.2 and 2.6. A conditional transaction has never been exempt: on develop the sequencer already refuses it with the same -32003 error and text. Only the eth_sendRawTransaction cell changes with the bump.
  • The mixed runtime masked the change. op-devstack/sysgo/mixed_runtime.go passed --txpool.minimum-priority-fee=1 --txpool.nolocals to every op-reth node; --txpool.nolocals disables reth's local exemptions, so every existing acceptance test already ran with the minimum enforced for every origin on both reth versions. Those defaults are kept; the test under this PR opts out per node.
  • Production sequencers do not set the flag. Local checkouts of k8s (master, 2026-10-14), infrastructure-services (main, 2026-10-14), devnets (main, 2026-10-09) and devnets-private (2026-09-24) carry op-reth txpool flags (--txpool.max-new-pending-txs-notifications=1000, --txpool.max-account-slots=1000 on op-opn-reth-f-sequencer-{4,5,6} for OP Mainnet and OP Sepolia, and netchef's reth_extra_args.go), but none sets --txpool.minimum-priority-fee or --txpool.nolocals. reth's default for the minimum is unset (no floor at all), so reth#26861 changes nothing for those sequencers unless an operator adds the flag. (The only hit, base/base's crates/execution/node/src/node.rs, is Base's own node source wiring the CLI value through, not a configuration.) Note that local checkouts can lag the live repos.

Seams added

  • sysgo.OpRethWithTxPoolMinimumPriorityFee(wei) and sysgo.OpRethWithTxPoolLocalExemptions(): config fields rather than extra args, because the mixed runtime passes both flags itself and op-reth rejects a repeated flag. txPoolNodeArgs is extracted from buildMixedOpRethNode and unit-tested.
  • sysgo.OpRethWithTxConditional(): --rollup.enable-tx-conditional.
  • dsl.L2ELNode.SendRawTransaction / SendRawTransactionConditional returning a dsl.TransactionSubmission with IsAccepted() and IsRejectedWith(code, message), in the shape of ForkchoiceUpdateResult, and dsl.L2ELNode.VerifyTransactionUnknown(hash). The condition is the DSL's own dsl.TransactionConditional (block number and timestamp bounds) rather than op-geth's types.TransactionConditional, which upstream go-ethereum lacks and docs/ai/opgeth-decoupling.md keeps out of the DSL; it always sends knownAccounts as an empty object, since op-reth's decoder refuses null there.
  • eth.TransactionRejected (-32003).

Local verification

Unit: go test ./op-devstack/sysgo/ -run 'TxPool|OpRethWith|ProofsHistory|MixedL2EL', go test ./op-service/eth/ ./op-service/txplan/ pass; op-golangci-lint run on the changed packages reports 0 issues.

Acceptance, with -parallel 2 and RUST_BINARY_PATH_OP_RETH pointing at the binary under test:

DEVSTACK_ORCHESTRATOR=sysgo RUST_BINARY_PATH_OP_RETH=<binary> go test -count=1 -timeout 40m -parallel 2 \
  -run 'TestSequencerRejectsATransactionBelowTheMinimumPriorityFee|TestSequencerIncludesATransactionAtTheMinimumPriorityFee' \
  -v ./op-acceptance-tests/tests/op_reth_txpool_minimum_priority_fee/
  • develop op-reth (debug build of this branch), op-node: ok ... 26.0s before the review fixes and ok ... 25.0s after them; Rejects/eth_sendRawTransaction SKIP, Rejects/eth_sendRawTransactionConditional PASS, Includes/* PASS.
  • develop op-reth with the skip removed: Rejects/eth_sendRawTransaction FAIL, as the skip message states: eth_sendRawTransaction must refuse transaction 0xc9c74c… on sequencer: An error is expected but got nil after Transaction accepted ... method=eth_sendRawTransaction tip=999,999,999.
  • rust!: update reth to v2.6.0 #23046 op-reth (built from its head 93d9ec9) with the skip removed, op-node: all four cells PASS; the raw refusal reads err="transaction priority fee below minimum required priority fee 1000000000" with code -32003.
  • develop op-reth, kona-node (DEVSTACK_L2CL_KIND=kona-node): ok ... 31.8s, the same cells as under op-node (Rejects/eth_sendRawTransaction SKIP, the other three PASS).

Closes #23400

@einar-oplabs einar-oplabs changed the title op-acceptance-tests,op-devstack: hold the sequencer to the txpool minimum priority fee on local transactions op-acceptance-tests,op-devstack,op-service: hold the sequencer to the txpool minimum priority fee on local transactions Nov 10, 2026
@einar-oplabs
einar-oplabs requested a review from aakoshh November 10, 2026 14:07
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch from 6e5aef7 to 4e677a2 Compare November 10, 2026 14:53
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch from 4e677a2 to 2a37ccd Compare November 11, 2026 12:28
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch from 2a37ccd to 3949dae Compare November 11, 2026 13:59
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch 2 times, most recently from 2c72161 to 3c32af6 Compare November 11, 2026 15:28
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch from 3c32af6 to b4deadc Compare November 11, 2026 16:28
… txpool minimum priority fee on local transactions

reth 2.6 (reth#26861) applies --txpool.minimum-priority-fee to every
transaction origin, where reth 2.5.2 exempts transactions submitted over
the node's own RPC. Add an acceptance test with an op-reth sequencer
running the flag the way production would, without --txpool.nolocals: a
transfer one wei under the minimum must be refused with the pool's
-32003 error through eth_sendRawTransaction and through
eth_sendRawTransactionConditional, and one at the minimum must be
included. The conditional path enters the pool as a private transaction
and has never been exempt.

The mixed runtime passed --txpool.minimum-priority-fee=1 and
--txpool.nolocals to every op-reth node, and op-reth rejects a repeated
flag, so both, and the tx-conditional flag, become OpRethConfig fields
with options to set the minimum (zero disables it) and to keep reth's
local exemptions. The DSL gains SendRawTransaction and
SendRawTransactionConditional returning the node's answer for the test
to judge, FunderEOA.WithFundingOptions so every funding transaction can
carry a tip, and eth.TransactionRejected names the -32003 code.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@einar-oplabs
einar-oplabs force-pushed the einar/23400-txpool-min-priority-fee branch from b4deadc to a4c44ac Compare November 12, 2026 17:25
@einar-oplabs
einar-oplabs marked this pull request as ready for review November 13, 2026 13:18
@einar-oplabs
einar-oplabs requested a review from a team as a code owner November 13, 2026 13:18
@joshklop
joshklop added this pull request to stack #24333 November 21, 2026 22:31
@joshklop joshklop closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants