Skip to content

justfile: add test-proof-exex for the proofs-history ExEx coverage - #23507

Closed
einar-oplabs wants to merge 1 commit into
developfrom
einar/test-proof-exex-just
Closed

einar-oplabs wants to merge 1 commit into
developfrom
einar/test-proof-exex-just

Conversation

@einar-oplabs

@einar-oplabs einar-oplabs commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Why

The proofs-history ExEx test coverage written for the reth v2.6.0 bump (#23385, #23386) has no single local entry point; running it means knowing four crates, eleven acceptance packages and an e2e suite by name.

What

just test-proof-exex runs the trie, ExEx, RPC and CLI Rust suites, the proofs_history_* acceptance packages and the proofs e2e suite; every step runs and the recipe fails at the end naming the failed steps. just test-reth-bump runs the op_reth_* acceptance packages. Both build the contracts through build-devstack-contracts, which adds the MockSP1Verifier artifact the devstack deployer needs and build-no-tests skips (#24009), and the release Rust binaries. The acceptance steps run whichever matching packages exist, so the recipes work on develop before those packages land. Neither recipe is wired into CI.

Verified with just -n on all three recipes and full runs of the same steps on develop at 2885809 with op-node and with kona-node (Rust 703 run, 701 passed, the two failures being the #464 cases kept ignored on #23451; all acceptance packages ok on both CLs; e2e 53 passed, 1 skipped naming protocol-team#683).

Breakdown

added removed net
implementation 73 0 +73
tests 0 0 0
docs 0 0 0

AI Reviews

  • 2026-11-13T12:28:00+01:00 0b67c18 Opus 5.5 medium

🤖 Generated with Claude Code

@einar-oplabs einar-oplabs self-assigned this Oct 19, 2026
@opgitgovernance

Copy link
Copy Markdown
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Nov 3, 2026
@einar-oplabs einar-oplabs removed the S-stale Status: Will be closed unless there is activity label Nov 6, 2026
@einar-oplabs
einar-oplabs force-pushed the einar/23392-proofs-slow-store branch from 1ff0afe to 323d91a Compare November 9, 2026 22:30
@einar-oplabs
einar-oplabs force-pushed the einar/test-proof-exex-just branch from 7fa64de to 9f600fd Compare November 9, 2026 22:30
@einar-oplabs
einar-oplabs force-pushed the einar/23392-proofs-slow-store branch from 323d91a to b691317 Compare November 9, 2026 23:25
@einar-oplabs
einar-oplabs force-pushed the einar/test-proof-exex-just branch from a73a6d3 to b879bee Compare November 9, 2026 23:25
@einar-oplabs
einar-oplabs force-pushed the einar/23392-proofs-slow-store branch from b691317 to 5ad8024 Compare November 9, 2026 23:47
@einar-oplabs
einar-oplabs force-pushed the einar/test-proof-exex-just branch from b879bee to 439abb8 Compare November 9, 2026 23:47
Adds the local entry points for the test coverage written for the reth
v2.6.0 bump: test-proof-exex runs the Rust suites of the trie, ExEx, RPC
and CLI crates, the proofs_history_* acceptance packages and the proofs
e2e suite; test-reth-bump runs the op_reth_* acceptance packages. Both
build the contracts through build-devstack-contracts, which adds the
MockSP1Verifier artifact the devstack deployer needs and build-no-tests
skips, and the release Rust binaries. The acceptance steps run whichever
matching packages exist, so the recipes work before those packages land.
Neither recipe is wired into CI.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@einar-oplabs
einar-oplabs force-pushed the einar/test-proof-exex-just branch from 439abb8 to 0b67c18 Compare November 13, 2026 11:24
@einar-oplabs
einar-oplabs changed the base branch from einar/23392-proofs-slow-store to develop November 13, 2026 11:24
@wiz-0f98cca50a

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 9 Medium 2 Low
Software Management Finding Software Management Findings -
Total 9 Medium 2 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@einar-oplabs
einar-oplabs marked this pull request as ready for review November 13, 2026 11:44
@einar-oplabs
einar-oplabs requested a review from a team as a code owner November 13, 2026 11:44
@joshklop joshklop closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants