Repository navigation
justfile: add test-proof-exex for the proofs-history ExEx coverage - #23507
Closed
einar-oplabs wants to merge 1 commit into
Closed
einar-oplabs wants to merge 1 commit into
einar-oplabs wants to merge 1 commit into
Conversation
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
einar-oplabs
force-pushed
the
einar/23392-proofs-slow-store
branch
from
November 9, 2026 22:30
1ff0afe to
323d91a
Compare
einar-oplabs
force-pushed
the
einar/test-proof-exex-just
branch
from
November 9, 2026 22:30
7fa64de to
9f600fd
Compare
einar-oplabs
force-pushed
the
einar/23392-proofs-slow-store
branch
from
November 9, 2026 23:25
323d91a to
b691317
Compare
einar-oplabs
force-pushed
the
einar/test-proof-exex-just
branch
from
November 9, 2026 23:25
a73a6d3 to
b879bee
Compare
einar-oplabs
force-pushed
the
einar/23392-proofs-slow-store
branch
from
November 9, 2026 23:47
b691317 to
5ad8024
Compare
einar-oplabs
force-pushed
the
einar/test-proof-exex-just
branch
from
November 9, 2026 23:47
b879bee to
439abb8
Compare
Adds the local entry points for the test coverage written for the reth v2.6.0 bump: test-proof-exex runs the Rust suites of the trie, ExEx, RPC and CLI crates, the proofs_history_* acceptance packages and the proofs e2e suite; test-reth-bump runs the op_reth_* acceptance packages. Both build the contracts through build-devstack-contracts, which adds the MockSP1Verifier artifact the devstack deployer needs and build-no-tests skips, and the release Rust binaries. The acceptance steps run whichever matching packages exist, so the recipes work before those packages land. Neither recipe is wired into CI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
einar-oplabs
force-pushed
the
einar/test-proof-exex-just
branch
from
November 13, 2026 11:24
439abb8 to
0b67c18
Compare
einar-oplabs
changed the base branch from
einar/23392-proofs-slow-store
to
develop
November 13, 2026 11:24
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The proofs-history ExEx test coverage written for the reth v2.6.0 bump (#23385, #23386) has no single local entry point; running it means knowing four crates, eleven acceptance packages and an e2e suite by name.
What
just test-proof-exexruns the trie, ExEx, RPC and CLI Rust suites, theproofs_history_*acceptance packages and the proofs e2e suite; every step runs and the recipe fails at the end naming the failed steps.just test-reth-bumpruns theop_reth_*acceptance packages. Both build the contracts throughbuild-devstack-contracts, which adds theMockSP1Verifierartifact the devstack deployer needs andbuild-no-testsskips (#24009), and the release Rust binaries. The acceptance steps run whichever matching packages exist, so the recipes work on develop before those packages land. Neither recipe is wired into CI.Verified with
just -non all three recipes and full runs of the same steps on develop at 2885809 with op-node and with kona-node (Rust 703 run, 701 passed, the two failures being the #464 cases kept ignored on #23451; all acceptance packages ok on both CLs; e2e 53 passed, 1 skipped naming protocol-team#683).Breakdown
AI Reviews
🤖 Generated with Claude Code