Skip to content

op-reth: run eth_call and eth_estimateGas at pending on the subblock state - #23595

Closed
asdv23 wants to merge 1 commit into
ethereum-optimism:developfrom
asdv23:fix/op-reth-flashblocks-pending-call-env
Closed

asdv23 wants to merge 1 commit into
ethereum-optimism:developfrom
asdv23:fix/op-reth-flashblocks-pending-call-env

Conversation

@asdv23

@asdv23 asdv23 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

With --flashblocks-url, eth_call, eth_estimateGas and the other calls at pending ran on latest instead of the subblock. They now run on the subblock's state and header.

Closes #23592. The canonical-tip guard is left to #22817.

rust-code-reviewer ran; security-review skipped (no new input surface).

@asdv23
asdv23 requested a review from a team as a code owner October 22, 2026 11:44
@asdv23
asdv23 force-pushed the fix/op-reth-flashblocks-pending-call-env branch from d583716 to e2e52d1 Compare October 26, 2026 03:20
@asdv23

asdv23 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

@sebastianst @geoknee could you take a look? Rebased on develop (Rust 1.99). CI needs maintainer authorization; head is 947470c9103a0099e0e4e07e04422de225b10ab1.

@asdv23
asdv23 force-pushed the fix/op-reth-flashblocks-pending-call-env branch from e2e52d1 to 947470c Compare October 26, 2026 06:09
@sebastianst

Copy link
Copy Markdown
Member

/ci authorize 947470c

@asdv23

asdv23 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @sebastianst! The authorization doesn't seem to have started CI: 947470c still has no bailiff or ci/circleci statuses. Could you retry when you get a chance?

@sebastianst

Copy link
Copy Markdown
Member

/ci authorize 947470c

@asdv23
asdv23 force-pushed the fix/op-reth-flashblocks-pending-call-env branch from 947470c to 98eecf9 Compare November 16, 2026 03:15
@asdv23

asdv23 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

@sebastianst thanks for authorizing it twice. Neither attempt started CI because Bailiff is down: 947470c never got a bailiff status, and no external-fork/… branch was pushed for it. #23946 and #23984 hit the same thing and got CI through #24052 and #24151 instead. Could you open a "CI run for #23595" PR the same way?

I've rebased on develop to clear the conflict with #24024; the head is now 98eecf91025666bd67de50caf045b19384c0ee1c. Two changes came with the rebase:

  • The pending_block_env_and_cfg override is re-derived against op-v2.7.0-1. Its tag moves from op-v2.6.0-1.
  • Since rust!: Update reth to v2.7.0 #24024, local_pending_state opens a canonical pending tip through state_with_block_appended. MockEthProvider returns UnsupportedProvider for that call, so the pending-call tests now use a database-backed BlockchainProvider, as pending_flashblock_state_includes_every_pending_block does. calls_at_pending_run_on_the_pending_flashblock still fails without the override.

Locally, the reth-optimism-rpc nextest, clippy (--all-features --all-targets -D warnings), rustdoc, fmt --check and just check-upstream-mirrors all pass.

@asdv23 asdv23 closed this by deleting the head repository Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-reth: eth_call and eth_estimateGas at pending ignore the subblock state

2 participants