Repository navigation
Conversation
Extends the regression test to debug_traceBlock (raw), debug_traceBlockByNumber, debug_intermediateRoots and trace_replayBlockTransactions. Fails without executor-backed block replays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up the replay extension points on Trace. Also adds the trace types and revm-inspectors to reth-optimism-rpc for the block-level overrides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpEthApi overrides the Trace extension points (trace_block_transactions, debug_trace_block_transactions, debug_trace_chain_block_transactions, block_intermediate_roots) to replay through the block executor. Fixes debug_traceBlock* including raw blocks, debug_intermediateRoots, traceChain, and trace_block / trace_replayBlockTransactions / trace_filter / ots block traces. debug_traceBadBlock now fails on blocks the executor rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Superseded by #23670, which combines the per-transaction and block-level overrides on ethereum-optimism/reth#26. Tracked in ethereum-optimism/protocol-team#485. Closing as superseded; branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of the plan in ethereum-optimism/protocol-team#485, stacked on #23615: settle SDM refunds in the block-level RPC replays.
Pins reth to ethereum-optimism/reth#25, which moves reth's block replay loops behind defaulted
Tracemethods without changing their behavior.OpEthApioverrides them to replay through the block executor:trace_block_transactions(trace_block,trace_replayBlockTransactions,trace_filter,ots_*block traces),debug_trace_block_transactions(debug_traceBlockByHash/ByNumber, rawdebug_traceBlock,debug_traceBadBlock),debug_trace_chain_block_transactions(traceChain) andblock_intermediate_roots(debug_intermediateRoots).debug_traceBadBlockgoes through the executor too, so a bad block that the executor rejects (block gas, DA footprint, SDM refund-list validation) now fails to trace instead of tracing pre-refund. A bare-EVM fallback for that case is possible if we want it.The regression test now also covers raw
debug_traceBlock(canonical gas again, as in @pcw109550's repro on #485),debug_traceBlockByNumber,debug_intermediateRootsandtrace_replayBlockTransactions. Those assertions fail without the overrides and pass with them; the op-rethitsuite passes, clippy is clean andjust check-upstream-mirrorspasses.Do not merge yet: the reth pin is the head of the unmerged ethereum-optimism/reth#25. Repin to the merged fork commit or tag, and move optimism-premium's reth pin in step.
🤖 Generated with Claude Code