Repository navigation
kona-node: add verifier L1 confirmation depth - #23696
Merged
Merged
Conversation
teddyknox
previously approved these changes
Oct 29, 2026
Contributor
Author
|
@OptimismBot re-approve |
OptimismBot
previously approved these changes
Oct 29, 2026
OptimismBot
left a comment
There was a problem hiding this comment.
Re-approved after reviewing the semantic delta since the latest eligible human approval.
Contributor
Author
|
@OptimismBot re-approve |
OptimismBot
approved these changes
Oct 29, 2026
OptimismBot
left a comment
There was a problem hiding this comment.
Re-approved after reviewing the semantic delta since the latest eligible human approval.
teddyknox
approved these changes
Oct 29, 2026
joshklop
enabled auto-merge
October 29, 2026 16:59
teddyknox
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kona derives through the L1 tip and lacks op-node’s configurable delay, so shallow L1 reorgs can trigger recovery while Go peers configured with confirmations continue deriving. Add
--verifier.l1-confs/KONA_NODE_VERIFIER_L1_CONFSto delay online derivation in both validator and sequencer modes. The default is 0, matching op-node; setting it to 4 keeps derivation four blocks behind the observed L1 head.This PR is independent of #23548 and replaces the checkpoint-retention approach in #23673. Recovery correctness remains in #23548. Related to protocol-team#328.
The Go/Kona acceptance test replaces a consumed L1 tip at zero confirmations and an unconsumed tip at four confirmations, then checks canonical derivation, reset behavior, and safe-chain recovery. Standard acceptance-suite discovery runs both clients together in the op-node CI variant; the Kona variant skips the duplicate fixed fixture. No CI configuration changes are needed. Reset initialization retains canonical L1 resolution even inside the confirmation window.
Validation: all 491 affected Rust tests pass with all features and zero skips, along with full Rust lint and all proof-platform/no_std checks. The live Go/Kona reorg acceptance test passes on this PR alone: each client resets once at depth 0 and neither resets at depth 4. Full Go lint and upstream API checks pass; independent Rust, Go, and CI reviews find no remaining issues.