Repository navigation
op-devstack,op-acceptance-tests: drop kona-node skips that no longer apply - #23856
Merged
Merged
Conversation
…skipping them on kona-node The confirmations and safedb_parity tests pin the CL kind of every node, so they have no kona-node gap. They now run only in the kona-node variant, through RunOnceOnCL, and no longer show up as SkipOnKonaNode skips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kona-node serves the pre-interop superroot_atTimestamp RPC, so the non-interop ZK proposer and challenger tests no longer need to skip it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshklop
commented
Nov 3, 2026
…Database against kona-node kona-node's SafeDB persists safe-head history across a CL restart, so the test no longer needs to skip it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
geoknee
previously approved these changes
Nov 3, 2026
Drop RunOnceOnCL per review: running the seven CL-pinned tests in both the op-node and kona-node jobs is redundant but less brittle than gating them on DEVSTACK_L2CL_KIND. Document that in the AI acceptance test notes, and trim the NewOpNodeSuperRoots doc comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshklop
enabled auto-merge
November 3, 2026 15:37
geoknee
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kona-node skip list now contains only open parity gaps, so it can be read as the remaining work before
SkipOnKonaNode(andSkipOnOpNode) can be removed. Nothing changes for operators or chains; this only moves where tests run in CI.The
derivation/confirmationstest and the sixsafedb_paritytests pin op-node and kona-node side by side, so they have no kona-node gap. They usedSkipOnKonaNodeonly to avoid running twice across the CL matrix. The skip is removed, so they now run in both the op-node and kona-node jobs. That repeats the same run, but it is simpler than gating onDEVSTACK_L2CL_KIND;docs/ai/acceptance-tests.mdnow says to accept the repeat.The non-interop ZK proposer and challenger tests skipped kona-node because it lacked the single-chain
superroot_atTimestampRPC; kona-node serves it since #23590. Both tests pass locally against kona-node/op-reth with the skip removed.TestNotTruncateDatabaseOnRestartWithExistingDatabaseskipped kona-node because the safe-head history did not survive a CL restart; kona-node persists it since #23583 and #23590. It passed three of three local runs against kona-node/op-reth. #23787 drops its own removal of this skip so it lands here.For the reviewer: the seven CL-pinned tests now also run in the kona-node job (
2xlarge.gen2), whose resource class comment is sized from a peak measured without them. Watch the kona-node job's memory for the first few runs.Closes #23853
Closes #23854
Closes #23855
Closes #22265
Review findings dismissed (
go-code-reviewerand a general review; no other review agent's trigger matches this diff):dsl.NewOpNodeSuperRootsnow that it can wrap kona-node: out of scope; its doc comment is updated.🤖 Generated with Claude Code