Skip to content

op-devstack,op-acceptance-tests: drop kona-node skips that no longer apply - #23856

Merged
joshklop merged 4 commits into
developfrom
joshklop/kona-parity-tests-skip-op-node
Nov 3, 2026
Merged

joshklop merged 4 commits into
developfrom
joshklop/kona-parity-tests-skip-op-node

Conversation

@joshklop

@joshklop joshklop commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The kona-node skip list now contains only open parity gaps, so it can be read as the remaining work before SkipOnKonaNode (and SkipOnOpNode) can be removed. Nothing changes for operators or chains; this only moves where tests run in CI.

The derivation/confirmations test and the six safedb_parity tests pin op-node and kona-node side by side, so they have no kona-node gap. They used SkipOnKonaNode only to avoid running twice across the CL matrix. The skip is removed, so they now run in both the op-node and kona-node jobs. That repeats the same run, but it is simpler than gating on DEVSTACK_L2CL_KIND; docs/ai/acceptance-tests.md now says to accept the repeat.

The non-interop ZK proposer and challenger tests skipped kona-node because it lacked the single-chain superroot_atTimestamp RPC; kona-node serves it since #23590. Both tests pass locally against kona-node/op-reth with the skip removed.

TestNotTruncateDatabaseOnRestartWithExistingDatabase skipped kona-node because the safe-head history did not survive a CL restart; kona-node persists it since #23583 and #23590. It passed three of three local runs against kona-node/op-reth. #23787 drops its own removal of this skip so it lands here.

For the reviewer: the seven CL-pinned tests now also run in the kona-node job (2xlarge.gen2), whose resource class comment is sized from a peak measured without them. Watch the kona-node job's memory for the first few runs.

Closes #23853
Closes #23854
Closes #23855
Closes #22265

Review findings dismissed (go-code-reviewer and a general review; no other review agent's trigger matches this diff):

  • Rename dsl.NewOpNodeSuperRoots now that it can wrap kona-node: out of scope; its doc comment is updated.

🤖 Generated with Claude Code

joshklop and others added 2 commits November 2, 2026 19:55
…skipping them on kona-node

The confirmations and safedb_parity tests pin the CL kind of every node, so
they have no kona-node gap. They now run only in the kona-node variant,
through RunOnceOnCL, and no longer show up as SkipOnKonaNode skips.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kona-node serves the pre-interop superroot_atTimestamp RPC, so the
non-interop ZK proposer and challenger tests no longer need to skip it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joshklop
joshklop requested a review from a team as a code owner November 3, 2026 03:56
…Database against kona-node

kona-node's SafeDB persists safe-head history across a CL restart, so the
test no longer needs to skip it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joshklop joshklop changed the title op-devstack,op-acceptance-tests: drop kona-node skips that are not parity gaps op-devstack,op-acceptance-tests: drop kona-node skips that no longer apply Nov 3, 2026
geoknee
geoknee previously approved these changes Nov 3, 2026
Comment thread op-devstack/dsl/super_root_source.go Resolved
Comment thread op-devstack/sysgo/mixed_runtime.go Resolved
Drop RunOnceOnCL per review: running the seven CL-pinned tests in both
the op-node and kona-node jobs is redundant but less brittle than
gating them on DEVSTACK_L2CL_KIND. Document that in the AI acceptance
test notes, and trim the NewOpNodeSuperRoots doc comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joshklop
joshklop added this pull request to the merge queue Nov 3, 2026
Merged via the queue into develop with commit c6d4096 Nov 3, 2026
55 of 56 checks passed
@joshklop
joshklop deleted the joshklop/kona-parity-tests-skip-op-node branch November 3, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants