Repository navigation
Conversation
A derivation pipeline reset that failed left derivation in AwaitingUpdateAfterSignal, so the next L1 head or EL sync completion resumed derivation on a pipeline that had never reset. Nothing sent the reset again. Keep a failed reset pending and adopt its head, since the engine is already there. attempt_derivation retries the pending reset before every step, and waits for the next L1 head if the retry fails. The one-time reset work (clearing the origin and finalizer, truncating the safe head database) runs once when the reset arrives, not on every retry, and EL sync completion retargets a pending reset to the head it truncated to. A critical pipeline error from a signal now stops the actor instead of being retried forever. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshklop
force-pushed
the
joshklop/kona-derivation-reset-retry
branch
from
November 3, 2026 05:00
555d7ca to
4ec0486
Compare
Contributor
Author
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a derivation pipeline reset failed, kona-node's derivation actor resumed anyway. The next L1 head or EL sync completion stepped a pipeline that had never reset, and nothing sent the reset again. A failed reset now stays pending and is retried before every derivation step, waiting for the next L1 head if it fails again. The derivation actor clears its origin and finalizer and truncates the safe head database once, when the reset arrives, not on every retry. A critical pipeline error from a signal now stops the actor, as in op-node, instead of being retried forever.
Operators see no new flags. A node whose pipeline reset fails, for example during an L1 or L2 RPC outage, now recovers once the reset succeeds instead of deriving from stale pipeline state.
This leaves one known gap. Derivation can still send attributes and finalizations from its old pipeline after an engine reset, for the requests queued ahead of the reset signal. A late safe-head update that arrives after a failed reset still stops the actor, as one after a successful reset does on develop. #23859, stacked on this PR, makes the two actors count resets and drop stale work, which closes both.
Split out of #23548. Reviewed with the
rust-code-reviewerandsafedb-revieweragents.🤖 Generated with Claude Code