Repository navigation
op-reth: reuse the Lagoon fixture and unused-port default in node tests - #23973
Closed
einar-oplabs wants to merge 2 commits into
Closed
einar-oplabs wants to merge 2 commits into
einar-oplabs wants to merge 2 commits into
Conversation
…replay Pins reth to the fork tag op-v2.6.0-4, which replays every block transaction through the block executor (ethereum-optimism/reth#37, a backport of paradigmxyz/reth#28266), so debug, trace and otterscan replays report SDM-settled gas and balances with no override in op-reth. Related to ethereum-optimism/protocol-team#485. Adds the integration tests that pin the behavior on a sequenced Lagoon block with refunded, unrefunded, refund-dependent and reverting transactions: per-transaction gas against receipts, prestate and parity state diffs against `debug_accountAt`, intermediate roots per boundary, the post-exec transaction as a replay target, a synthetic call at an index that earns no refund, call-many on the settled prefix, `trace_filter`, `traceChain` with its per-block error shape, and otterscan revert data. Raw blocks trace with settled gas, and a raw block the executor rejects returns the executor's error. An alloy-op-evm unit test pins that a Verify-mode result is settled before commit with an inspector enabled. Shared fixtures and node helpers live in the Lagoon fixture module. The reth update guide documents the carried patch and the fork tagging rules. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The derived-attributes test builds its Lagoon-at-genesis spec through the shared fixture instead of a second copy of the Jovian genesis recipe, and ten node setups drop the discv5 ports they set by hand after `with_unused_ports()`, which already zeroes them. Test-only. Related to ethereum-optimism/protocol-team#485. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last duplicate of the Lagoon genesis recipe and ten redundant discv5 port lines from the op-reth node tests.
Stacked on #23942, which adds the shared Lagoon-at-genesis fixture in
lagoon.rs; the base retargets todeveloponce that merges. Related to ethereum-optimism/protocol-team#485.The Jovian genesis recipe still had a second copy in the derived-attributes test, and ten node setups set the discv5 ports by hand after
with_unused_ports(), which already zeroes them. The next genesis tweak would have to land in two places or the suites diverge. The derived-attributes test now builds its spec through the shared fixture, and the hand-set ports go with theirmutbindings. Test-only; no effect on users.Left as is: the payload-attributes closure in the derived-attributes test applies the Jovian fields only on a Jovian spec, so it is not the unconditional shared helper; the all-modules RPC node config in
rpc.rsserves a test that is not Lagoon-specific, so it stays until the generic helpers move out of the Lagoon module.Review record:
rust-code-reviewerran on the diff and reported no findings.Breakdown
AI Reviews
🤖 Generated with Claude Code