Skip to content

op-reth: reuse the Lagoon fixture and unused-port default in node tests - #23973

Closed
einar-oplabs wants to merge 2 commits into
developfrom
einar/lagoon-fixture-reuse-485
Closed

einar-oplabs wants to merge 2 commits into
developfrom
einar/lagoon-fixture-reuse-485

Conversation

@einar-oplabs

Copy link
Copy Markdown
Contributor

Removes the last duplicate of the Lagoon genesis recipe and ten redundant discv5 port lines from the op-reth node tests.

Stacked on #23942, which adds the shared Lagoon-at-genesis fixture in lagoon.rs; the base retargets to develop once that merges. Related to ethereum-optimism/protocol-team#485.

The Jovian genesis recipe still had a second copy in the derived-attributes test, and ten node setups set the discv5 ports by hand after with_unused_ports(), which already zeroes them. The next genesis tweak would have to land in two places or the suites diverge. The derived-attributes test now builds its spec through the shared fixture, and the hand-set ports go with their mut bindings. Test-only; no effect on users.

Left as is: the payload-attributes closure in the derived-attributes test applies the Jovian fields only on a Jovian spec, so it is not the unconditional shared helper; the all-modules RPC node config in rpc.rs serves a test that is not Lagoon-specific, so it stays until the generic helpers move out of the Lagoon module.

Review record: rust-code-reviewer ran on the diff and reported no findings.

Breakdown

added removed net
implementation 0 0 0
tests 19 50 -31
docs 0 0 0
total 19 50 -31

AI Reviews

  • Claude: Fable 5.1 (xhigh)
  • Codex: GPT-6.1-Sol (xhigh)

🤖 Generated with Claude Code

einar-oplabs and others added 2 commits November 6, 2026 06:48
…replay

Pins reth to the fork tag op-v2.6.0-4, which replays every block
transaction through the block executor (ethereum-optimism/reth#37, a
backport of paradigmxyz/reth#28266), so debug, trace and otterscan replays
report SDM-settled gas and balances with no override in op-reth. Related to
ethereum-optimism/protocol-team#485.

Adds the integration tests that pin the behavior on a sequenced Lagoon
block with refunded, unrefunded, refund-dependent and reverting
transactions: per-transaction gas against receipts, prestate and parity
state diffs against `debug_accountAt`, intermediate roots per boundary, the
post-exec transaction as a replay target, a synthetic call at an index that
earns no refund, call-many on the settled prefix, `trace_filter`,
`traceChain` with its per-block error shape, and otterscan revert data.
Raw blocks trace with settled gas, and a raw block the executor rejects
returns the executor's error. An alloy-op-evm unit test pins that a
Verify-mode result is settled before commit with an inspector enabled.

Shared fixtures and node helpers live in the Lagoon fixture module. The
reth update guide documents the carried patch and the fork tagging rules.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The derived-attributes test builds its Lagoon-at-genesis spec through the
shared fixture instead of a second copy of the Jovian genesis recipe, and
ten node setups drop the discv5 ports they set by hand after
`with_unused_ports()`, which already zeroes them. Test-only. Related to
ethereum-optimism/protocol-team#485.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@einar-oplabs einar-oplabs self-assigned this Nov 6, 2026
Base automatically changed from einar/sdm-executor-replay-485 to develop November 10, 2026 16:58
@joshklop joshklop closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants