Repository navigation
ci: run the full CI when change detection cannot diff against the base - #24027
Closed
einar-oplabs wants to merge 1 commit into
Closed
einar-oplabs wants to merge 1 commit into
einar-oplabs wants to merge 1 commit into
Conversation
collect-params.sh hid a failed diff against origin/<target> and fell back to the last commit's files, or to no files at all. Path gating then skipped the jobs for any change it did not see and passed their required gates: a PR whose last commit only touched docs/ took the docs-only fast path. A failed base diff now logs a warning and treats every path as changed, so every "any" pattern matches and no "all" fast path applies. The new test-collect-params.sh runs detection against a throwaway repo and the real routing.yml, and runs in the setup job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
einar-oplabs
force-pushed
the
einar/ci-change-detection-fail-safe
branch
from
November 13, 2026 13:41
e1e23db to
7d44ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the base diff failed (e.g. a deleted base branch), change detection used only the last commit's files, so a PR whose last commit touched only
docs/skipped CI and still passed all four required gates.What
git diff origin/<target>...HEAD,collect-params.shlogs a warning and treats every path as changed, so the full CI runs. TheHEAD~1/ empty fallback is removed.develop(empty diff).test-collect-params.sh(6 scenarios) runs in the setup job. Againstdevelopwith the base ref missing, it getsonly_docs_changes=trueandrust_changes_detected=false.Notes
circleci config validatewas not run locally (no CLI token); this PR's setup pipeline runs the new step.Breakdown
🤖 Generated with Claude Code