Repository navigation
Conversation
A rev pin on an open ethereum-optimism/reth PR is fine while the two PRs are developed together, but #24024 merged on one. Add `just check-reth-pin` and a required rust-reth-pin job that fails unless every fork crate in the lockfiles resolves through an op-<base>-<n> tag. It runs apart from the other jobs, so such a PR still gets its full CI result.
Member
|
🤖 Claude Opus 5.5 says: #24071 supersedes this PR. Both add the same required job ( #24071 now includes this PR's lockfile scan: every reth crate in every tracked
Like this PR, #24071 stays red until |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A PR that pins the
ethereum-optimism/rethfork by anything other than anop-<base>-<n>tag now fails the requiredrequired-rust-cicheck, through a newrust-reth-pinjob (just check-reth-pininrust/). The job runs alongside the others, so a PR on arevpin still gets the full CI result and is red only on this one check.Why
#24024 merged while it pinned the head of an open fork PR stack, before
op-v2.7.0-0existed.rust/UPDATING-RETH.md("Pinning a fork change") allows arevpin only while the fork and monorepo PRs are developed together, and requires the switch to a tag before merge, so a fork pin ondevelopis always a tag. Nothing enforced that, and a reviewer unfamiliar with the rule had no signal that the PR wasn't ready.How
The recipe reads the tracked
Cargo.lockfiles rather thanrust/Cargo.toml, so a fork crate pulled in transitively is caught too; the--lockedCI jobs already keep the lockfiles in step with the manifests. It fails closed: agitorgreperror fails the check instead of reading as "nothing untagged".Caveats
developpinsrev = "0447ceb…"today, and the fork has noop-v2.7.0-*tag yet. Untildevelopis re-pinned, this job is red on every PR that runsrust-ci, including this one. Land the re-pin first, or fold this into it. A release branch cut fromdevelopwhile it is rev-pinned inherits the red job the same way.revpin on upstreamparadigmxyz/rethstill passes, since the guide allows a merge commit on upstreammainwhen no release contains a needed fix.Alternatives
just lint: rejected, because the guide has you runjust lintbefore every push, and it would fail throughout the intendedrev-pinned development phase.ci-config-reviewerran on this diff. Its two findings are fixed: the recipe failed open on agit/greperror, and it rejected tags on an upstream pre-release base (op-v2.8.0-rc.1-0).circleci config validatewas not run (CLI unavailable); the merged config was checked withyqonly.🤖 Generated with Claude Code