Skip to content

op-reth: follow the op-v2.7.0-1 reth fixes in mirrored get_proof and build_pending_env - #24077

Merged
sebastianst merged 3 commits into
developfrom
seb/op-reth-v2.7.0-1-mirrors
Nov 12, 2026
Merged

sebastianst merged 3 commits into
developfrom
seb/op-reth-v2.7.0-1-mirrors

Conversation

@sebastianst

@sebastianst sebastianst commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Brings op-reth's own copies of two upstream reth symbols in line with fixes picked onto the op-v2.7.0 fork branch in ethereum-optimism/reth#44, and pins reth to the resulting op-v2.7.0-1 tag. A newer reth pin does not fix these copies.

The UPSTREAM-MIRROR tags advance to the new pin. Only the reth source string changes in Cargo.lock.

Known gap: the key-cap test covers the check function, not its position before the window check and permit; there is no EthApiExt test harness for that.

🤖 Co-created with Claude Opus 5.5

Base automatically changed from seb/reth-fork-tag-pin-gate to develop November 11, 2026 21:47
…build_pending_env

Pin reth to the head of ethereum-optimism/reth#44 (e1bf972), which picks
upstream fixes onto op-v2.7.0-0. This rev pin is temporary until the
op-v2.7.0-1 tag exists; the lockfile only changes the reth source.

Two picks change upstream code that op-reth mirrors:

- #27716 caps eth_getProof at DEFAULT_MAX_PROOF_SLOTS storage keys before a
  proof permit is taken. The proofs-history eth_getProof override now
  checks the same cap first, with upstream's error. eth_getMultiProof,
  which #27716 caps too, is not served by an OP node.
- #28431 takes the pending block's timestamp from the time block override,
  so the override selects the hardfork rules. OpNextBlockEnvAttributes'
  build_pending_env does the same.

The other mirror tags advance unchanged: their upstream symbols do not
differ between df85687 and e1bf972.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sebastianst
sebastianst marked this pull request as ready for review November 12, 2026 13:40
@sebastianst
sebastianst requested a review from a team as a code owner November 12, 2026 13:40
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sebastianst
sebastianst requested a review from aakoshh November 12, 2026 14:59

@aakoshh aakoshh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sebastianst
sebastianst enabled stacked auto-merge November 12, 2026 15:34
@sebastianst
sebastianst added this pull request to the merge queue Nov 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 12, 2026
@sebastianst
sebastianst added this pull request to the merge queue Nov 12, 2026
Merged via the queue into develop with commit f849888 Nov 12, 2026
116 checks passed
@sebastianst
sebastianst deleted the seb/op-reth-v2.7.0-1-mirrors branch November 12, 2026 16:05
davidtaikocha added a commit to taikoxyz/alethia-reth that referenced this pull request Nov 13, 2026
… fix (#267)

* fix(deps): bump OP Reth to op-v2.7.0-1 for the proof-history unwind fix

Pin reth-optimism-trie to optimism develop b636ba6, which carries
ethereum-optimism/optimism#23334 (keep proofs-history shard keys valid
on unwind). No op-reth release includes it yet, and that commit pins
OP's reth fork at op-v2.7.0-1, so every reth dependency moves with it.

- Align alloy (2.5.0), reth-codecs/reth-primitives-traits (0.8.x),
  alloy-hardforks and revm-database-interface with the OP workspace.
- Lock alloy-trie to 0.9.7, as OP does; 0.9.9 breaks reth-trie-common.
- Adapt to reth v2.7: StateProviderDatabase takes an EvmStateProvider,
  CancelOnDrop moved to reth-tasks, and CachedStateProvider only serves
  EVM reads, so the payload builder roots blocks through the uncached
  provider like upstream's Ethereum builder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(rpc): cap eth_getProof storage keys like reth v2.7

reth v2.7 rejects eth_getProof requests with more than
DEFAULT_MAX_PROOF_SLOTS (1024) storage keys (paradigmxyz/reth#27716),
but proof-history nodes serve eth_getProof through TaikoEthProofExt,
which bypasses that check. Copy it, with upstream's limit, error and
message, ahead of the permit, as ethereum-optimism/optimism#24077 does
for op-reth.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants