Skip to content

op-e2e: run all system tests on op-reth - #24091

Merged
sebastianst merged 3 commits into
developfrom
seb/op-e2e-unpin-opgeth-l2-tests
Nov 12, 2026
Merged

sebastianst merged 3 commits into
developfrom
seb/op-e2e-unpin-opgeth-l2-tests

Conversation

@sebastianst

@sebastianst sebastianst commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

The op-e2e system tests that are still pinned to the in-process op-geth L2 EL either test op-geth-only behaviour or don't test what their name says. This resolves each of them, so that the op-geth L2 EL can be removed from op-e2e (#21744). Test code only; users see no change.

  • TestPendingGasLimit tests op-geth's locally computed pending block (RollupComputePendingBlock with GasCeil), which op-reth doesn't implement. Deleted.
  • TestTxGossip never exercised EL gossip: with the sequencer-HTTP forwarder on, the verifier doesn't admit the transaction to its own pool and forwards it over HTTP. It was the only system test that sent a transaction to a verifier, so it becomes TestTxForwarding on op-reth, without the geth.WithP2P and geth.ConnectP2P helpers it alone used.
  • TestPendingBlockIsLatest and the DA throttling tests run on op-reth unchanged. The GasCeil option the DA tests set only applies to locally computed pending blocks, not to blocks built from payload attributes.
  • The pre-Regolith TestFees subtest passes on op-reth when unpinned (op-alloy,kona!,op-reth!: fix Bedrock deposit decoding and pin gas parity #22946 fixed the isSystemTx decoding it was pinned for). It is deleted anyway, with its pre-Regolith fee branches: every live chain activated Regolith together with Bedrock.

Skipped review: go-code-reviewer, because the diff deletes code and adds only a trimmed copy of an existing test.

Closes #21451
Part of #21744

🤖 Co-created with Claude Opus 5.5 and Claude Fable 5.2

sebastianst and others added 2 commits November 12, 2026 10:04
Resolve the system tests pinned to the in-process op-geth L2 EL:

- Delete TestPendingGasLimit. It tests op-geth's locally computed
  pending block (Miner.RollupComputePendingBlock with Miner.GasCeil),
  which op-reth doesn't implement.
- Run TestPendingBlockIsLatest on op-reth.
- Delete TestTxGossip. The verifier forwards txs to the sequencer over
  HTTP and doesn't admit them to its own pool, so the test never
  exercised EL gossip. Drop the geth.WithP2P and geth.ConnectP2P helpers
  it was the only user of.
- Run the DA throttling tests on op-reth. Their Miner.GasCeil option
  only applies to locally computed pending blocks, not to blocks built
  from payload attributes.
- Delete the pre-Regolith TestFees subtest and its pre-Regolith fee
  branches. Every live chain activated Regolith together with Bedrock.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@sebastianst sebastianst self-assigned this Nov 12, 2026
TestTxGossip was the only system test that sent a transaction to a
verifier. It never exercised gossip, but it did cover forwarding over the
verifier's sequencer endpoint end to end. Keep that as TestTxForwarding.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@sebastianst
sebastianst marked this pull request as ready for review November 12, 2026 13:39
@sebastianst
sebastianst requested a review from a team as a code owner November 12, 2026 13:39
@sebastianst sebastianst assigned nonsense and unassigned sebastianst Nov 12, 2026
@sebastianst
sebastianst added this pull request to the merge queue Nov 12, 2026
Merged via the queue into develop with commit 9a83aca Nov 12, 2026
91 of 92 checks passed
@sebastianst
sebastianst deleted the seb/op-e2e-unpin-opgeth-l2-tests branch November 12, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-e2e: Remove pre-Regolith tests and/or fix op-reth's system tx return type

2 participants