Repository navigation
op-e2e: run all system tests on op-reth - #24091
Merged
Merged
Conversation
Resolve the system tests pinned to the in-process op-geth L2 EL: - Delete TestPendingGasLimit. It tests op-geth's locally computed pending block (Miner.RollupComputePendingBlock with Miner.GasCeil), which op-reth doesn't implement. - Run TestPendingBlockIsLatest on op-reth. - Delete TestTxGossip. The verifier forwards txs to the sequencer over HTTP and doesn't admit them to its own pool, so the test never exercised EL gossip. Drop the geth.WithP2P and geth.ConnectP2P helpers it was the only user of. - Run the DA throttling tests on op-reth. Their Miner.GasCeil option only applies to locally computed pending blocks, not to blocks built from payload attributes. - Delete the pre-Regolith TestFees subtest and its pre-Regolith fee branches. Every live chain activated Regolith together with Bedrock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
TestTxGossip was the only system test that sent a transaction to a verifier. It never exercised gossip, but it did cover forwarding over the verifier's sequencer endpoint end to end. Keep that as TestTxForwarding. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
nonsense
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The op-e2e system tests that are still pinned to the in-process op-geth L2 EL either test op-geth-only behaviour or don't test what their name says. This resolves each of them, so that the op-geth L2 EL can be removed from op-e2e (#21744). Test code only; users see no change.
TestPendingGasLimittests op-geth's locally computed pending block (RollupComputePendingBlockwithGasCeil), which op-reth doesn't implement. Deleted.TestTxGossipnever exercised EL gossip: with the sequencer-HTTP forwarder on, the verifier doesn't admit the transaction to its own pool and forwards it over HTTP. It was the only system test that sent a transaction to a verifier, so it becomesTestTxForwardingon op-reth, without thegeth.WithP2Pandgeth.ConnectP2Phelpers it alone used.TestPendingBlockIsLatestand the DA throttling tests run on op-reth unchanged. TheGasCeiloption the DA tests set only applies to locally computed pending blocks, not to blocks built from payload attributes.TestFeessubtest passes on op-reth when unpinned (op-alloy,kona!,op-reth!: fix Bedrock deposit decoding and pin gas parity #22946 fixed theisSystemTxdecoding it was pinned for). It is deleted anyway, with its pre-Regolith fee branches: every live chain activated Regolith together with Bedrock.Skipped review:
go-code-reviewer, because the diff deletes code and adds only a trimmed copy of an existing test.Closes #21451
Part of #21744
🤖 Co-created with Claude Opus 5.5 and Claude Fable 5.2