Skip to content

rust: make the reth forward sweep reviewable - #24106

Merged
sebastianst merged 3 commits into
developfrom
seb/reth-forward-sweep-guide
Nov 13, 2026
Merged

sebastianst merged 3 commits into
developfrom
seb/reth-forward-sweep-guide

Conversation

@sebastianst

@sebastianst sebastianst commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Makes the reth forward sweep reviewable. During the review of ethereum-optimism/reth#44, the sweep's report was session notes only, its range stopped before fixes that merged later, and several candidates had no recorded verdict.

  • rust/scripts/reth-forward-prefilter.py: lists every fix, perf, security or revert commit newer than a fork pin, on upstream main and in newer release tags, deduplicated by patch id. For each it gives the first release containing it, whether the pin carries it as a hand-port, how many of its files exist at the pin, and whether it applies cleanly. It runs in seconds on a reth clone and ignores the user's color and external-diff config. Tests are in just test-upstream-mirrors.
  • New "Forward sweep" section in rust/UPDATING-RETH.md: both the updater and the reviewer run the sweep, so its steps live in the update guide:
    • Record the upstream tip.
    • Run the prefilter before reading.
    • Give every fix in range a verdict.
    • Re-sweep from the recorded tip before the fork PR merges.
    • Put the verdicts and the prefilter table in the fork PR.
    • Pick bar: by default, recommend a pick only for consensus, realistic node stability or a high- or critical-severity vulnerability, argue other important fixes case by case, and allow watch items.
  • docs/ai/reth-update-review.md: keeps only how a review reads the range, plus a new "Reviewing a fork pick PR" checklist: a range-diff per pick, a search for upstream reverts and follow-ups, and a rerun of the candidate list.
  • The update-reth skill and the reviewer agent point at the new section.

Suggested by @aakoshh in the review of #24101.

🤖 Co-created with Claude Opus 5.5

Record the upstream tip, prefilter candidates with a script, give every fix
in range a verdict, re-sweep before the fork PR merges, and add a checklist
for reviewing fork pick PRs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread rust/scripts/reth-forward-prefilter.py Resolved
Comment thread docs/ai/reth-update-review.md Resolved
@joshklop

Copy link
Copy Markdown
Contributor

@claude review

sebastianst and others added 2 commits November 13, 2026 11:22
The updater runs the sweep and the fork carries its picks, so its steps and
the pick bar belong in the update guide. The review guide keeps how a review
reads the range. The pick bar now also covers high- and critical-severity
vulnerabilities.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With color.ui=always or a diff.external tool, git patch-id read nothing from
git log -p, so the prefilter printed an empty table. Disable both and fail if
patch-id still reads no patches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread rust/UPDATING-RETH.md Resolved

@aakoshh aakoshh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sebastianst
sebastianst added this pull request to the merge queue Nov 13, 2026
Merged via the queue into develop with commit c588bb8 Nov 13, 2026
120 of 121 checks passed
@sebastianst
sebastianst deleted the seb/reth-forward-sweep-guide branch November 13, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants