Repository navigation
rust: make the reth forward sweep reviewable - #24106
Merged
Merged
Conversation
Record the upstream tip, prefilter candidates with a script, give every fix in range a verdict, re-sweep before the fork PR merges, and add a checklist for reviewing fork pick PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aakoshh
reviewed
Nov 12, 2026
Contributor
|
@claude review |
The updater runs the sweep and the fork carries its picks, so its steps and the pick bar belong in the update guide. The review guide keeps how a review reads the range. The pick bar now also covers high- and critical-severity vulnerabilities. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With color.ui=always or a diff.external tool, git patch-id read nothing from git log -p, so the prefilter printed an empty table. Disable both and fail if patch-id still reads no patches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aakoshh
reviewed
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the reth forward sweep reviewable. During the review of ethereum-optimism/reth#44, the sweep's report was session notes only, its range stopped before fixes that merged later, and several candidates had no recorded verdict.
rust/scripts/reth-forward-prefilter.py: lists every fix, perf, security or revert commit newer than a fork pin, on upstreammainand in newer release tags, deduplicated by patch id. For each it gives the first release containing it, whether the pin carries it as a hand-port, how many of its files exist at the pin, and whether it applies cleanly. It runs in seconds on a reth clone and ignores the user's color and external-diff config. Tests are injust test-upstream-mirrors.rust/UPDATING-RETH.md: both the updater and the reviewer run the sweep, so its steps live in the update guide:docs/ai/reth-update-review.md: keeps only how a review reads the range, plus a new "Reviewing a fork pick PR" checklist: a range-diff per pick, a search for upstream reverts and follow-ups, and a rerun of the candidate list.update-rethskill and the reviewer agent point at the new section.Suggested by @aakoshh in the review of #24101.
🤖 Co-created with Claude Opus 5.5