Repository navigation
Conversation
ValidatePostExecConformance now requires debug_traceBlockByHash to report receipt gasUsed for every transaction, and debug_traceTransaction to do so for the last refunded transaction, using the callTracer. Verifier agreement runs the same check on the verifier. A node whose RPC replay omits the SDM refund settlement (protocol-team#485) reports pre-refund gas and fails. The function is shared by check-lagoon and the SDM acceptance tests, so the check runs against live networks and in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
geoknee
marked this pull request as ready for review
November 19, 2026 20:31
Contributor
|
Claude: Could we extend this to check balances as well as gas, and on the other replay paths too? As it stands, it would miss two narrower regressions:
Suggested additions:
For the expected balances, This needs the |
nonsense
self-requested a review
November 20, 2026 09:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SDM blocks, an op-reth whose RPC replay skips the refund settlement traces refunded transactions at their pre-refund gas, while receipts and state are correct (protocol-team#485). The existing SDM conformance checks compare receipts and
debug_replaySDMBlock, so they pass on such a node.ValidatePostExecConformancenow also requirescallTracertraces to report receiptgasUsed:debug_traceBlockByHash, which covers the refunded transactions, the transactions after them and the 0x7D row;debug_traceTransactionof the last refunded transaction, whose replay includes every earlier refund.ValidateVerifierAgreementruns the same check on the verifier, which is the stock op-reth serving public RPC.This is a smaller alternative to #23795.
ValidatePostExecConformanceis shared bycheck-lagoon sdmand the SDM acceptance tests (op-acceptance-tests/tests/sdm/helpers_test.go), so one check runs against live networks and in CI on every PR. The full method-by-method replay coverage is in op-reth'srpc_replay_settlementintegration tests from #23942. This check detects the defect from the outside, using two methods the public RPC whitelist allows.Behaviour change:
check-lagoon sdmnow fails against images without the replay fix. Nodes on rethop-v2.6.0-4or later pass.--sdm-l2-verifiernow needs thedebug_namespace; it previously needed onlyeth_.debugandtraceon both sequencer and verifier (buildMixedOpRethNode).Validation:
go test ./op-chain-ops/pkg/sdm/ ./op-chain-ops/cmd/check-lagoon/...andgo vet(includingop-acceptance-tests/tests/sdm) pass.callTracer,onlyTopCall): on public sdm-net-0 block 9599713, all sevendebug_traceBlockByHashrows match receipts (deposit0xb44e, four refunded0x6195, 0x7D0x0), and so doesdebug_traceTransactionfor each refunded transaction. The negative control is the Nov 7 run on protocol-team#485: pre-fix images traced 66981 against receipt 24981 on the same methods.🤖 Generated with Claude Code