Skip to content

ci: log missing shard timings, clarify timings job comments - #24208

Merged
joshklop merged 2 commits into
developfrom
mds/ci-shard-timings-followup
Nov 17, 2026
Merged

joshklop merged 2 commits into
developfrom
mds/ci-shard-timings-followup

Conversation

@mds1

@mds1 mds1 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #24207 for the review comments there. No change to how tests are split.

  • shard-tests.sh logs No fetched timings for <job>, splitting by CircleCI's own when the _shard-timings dir is in the workspace but has no file for the job. If the hard-coded job list in memory-all-shard-timings falls behind a fork rename, the job log now says so.
  • The token comment points a future CIRCLE_TIMINGS_TOKEN at a restricted context on the job, since every job can read a project env var.
  • A comment notes that PR branches targeting proposal/* still fetch develop's timings. Tests develop lacks get the 1m default, so only the balance changes.

Checks

  • circleci config validate --next on the merged config, shellcheck and shfmt clean.
  • shard-tests.sh with a stub circleci: no dir (other callers) logs nothing and splits as before, dir without the file logs the line, dir with the file passes --timings-file.

🤖 Generated with Claude Code

@mds1
mds1 requested a review from a team as a code owner November 17, 2026 02:06
Base automatically changed from mds/ci-shard-timings-2 to develop November 17, 2026 02:12
mds1 and others added 2 commits November 16, 2026 18:36
Follow-up to review on #24207: shard-tests.sh logs when the timings dir
exists but has no file for the job, so a stale JOBS list shows up in the
log. Comments point a future token at a restricted context and note that
branches into proposal/* still fetch develop's timings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mds1
mds1 force-pushed the mds/ci-shard-timings-followup branch from 23a5612 to a0416a6 Compare November 17, 2026 02:36
@joshklop
joshklop enabled auto-merge November 17, 2026 02:40
@joshklop
joshklop added this pull request to the merge queue Nov 17, 2026
Merged via the queue into develop with commit 6c43e7a Nov 17, 2026
105 checks passed
@joshklop
joshklop deleted the mds/ci-shard-timings-followup branch November 17, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants