Repository navigation
ci: log missing shard timings, clarify timings job comments - #24208
Merged
Merged
Conversation
Follow-up to review on #24207: shard-tests.sh logs when the timings dir exists but has no file for the job, so a stale JOBS list shows up in the log. Comments point a future token at a restricted context and note that branches into proposal/* still fetch develop's timings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mds1
force-pushed
the
mds/ci-shard-timings-followup
branch
from
November 17, 2026 02:36
23a5612 to
a0416a6
Compare
joshklop
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24207 for the review comments there. No change to how tests are split.
shard-tests.shlogsNo fetched timings for <job>, splitting by CircleCI's ownwhen the_shard-timingsdir is in the workspace but has no file for the job. If the hard-coded job list inmemory-all-shard-timingsfalls behind a fork rename, the job log now says so.CIRCLE_TIMINGS_TOKENat a restricted context on the job, since every job can read a project env var.proposal/*still fetch develop's timings. Tests develop lacks get the 1m default, so only the balance changes.Checks
circleci config validate --nexton the merged config, shellcheck and shfmt clean.shard-tests.shwith a stubcircleci: no dir (other callers) logs nothing and splits as before, dir without the file logs the line, dir with the file passes--timings-file.🤖 Generated with Claude Code