Skip to content

rust: point the teardown-SIGSEGV retry at the renamed p2p test - #24263

Merged
teddyknox merged 4 commits into
developfrom
claude/keen-lehmann-9a3089
Nov 18, 2026
Merged

teddyknox merged 4 commits into
developfrom
claude/keen-lehmann-9a3089

Conversation

@teddyknox

@teddyknox teddyknox commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

One line switches a merge-queue safeguard back on. It has been silently off since 2026-10-16.

reth-optimism-node integration tests sometimes segfault at process exit, after the test has passed (#20973). op-reth-integration-tests is a required check, so a crash ejects whichever unrelated PR is in the merge queue. Before there was a mitigation, the crash recurred five times in about two months and repeatedly ejected PRs from the queue.

#21909 added the mitigation: nextest retries the crashing test, and a Slack alert reports each retry with the stack. The retry selects the test by exact name, peers_negotiate_eth_69. #23046 renamed the test to peers_negotiate_eth_71. nextest does not report a filter that matches nothing, so no check failed and nobody noticed.

  • On develop today: the filter matches 0 tests. The next crash fails the required check, and the Slack alert cannot fire.
  • With this PR: the filter matches p2p_version::peers_negotiate_eth_71. nextest retries a crash in a fresh process, the job stays green, and the alert fires.

The crash is still live: the same signature was seen this month in an RWX shadow run of the suite, on another test of the same binary.

The change is one line of test-runner configuration. It has no effect on users or on product code.

Left out on purpose, to keep this to one line:

  • The comment above the override still says peers_negotiate_eth_69.
  • The filter is still an exact name, so the next eth wire version rename disables it again.
  • The second test, from the RWX run, is not covered.

Related: #20973

Review notes: rust-code-reviewer and ci-config-reviewer ran on an earlier, wider version of this branch and left no open finding. They did not run on this one-line diff.

🤖 Generated with Claude Code

…de tests

The #20973 stopgap retries a test that dies with SIGSEGV during teardown,
after its body has passed. Its filter named
`p2p_version::peers_negotiate_eth_69` exactly. #23046 renamed that test to
`peers_negotiate_eth_71`, so the override has matched no test since then:
a crash fails the job again, with no retry and no Slack alert.

The same crash has now been seen on a second test of the same binary,
`invalid_post_exec::test_buffered_malformed_post_exec_child_is_invalid`.
Both tests start two nodes in one process with `setup(2)`. #20973 scoped
the crash to the p2p test because it was then the only such test; #23186
added two more.

The override now covers the three two-node tests of
`reth-optimism-node::it`:
- The p2p test, by an anchored regex on the eth version. The next version
  bump renames the test again and no longer disables the retry.
- The two `invalid_post_exec` tests, by exact name. One has crashed. The
  other builds its two nodes the same way and has no crash on record.

The crash has not been seen on a one-node test, so those tests stay under
the no-retries policy.

The two `invalid_post_exec` tests now install the fatal-signal handler, as
the p2p test does. A retried crash then leaves the faulting stack in the
JUnit report, which is what the Slack alert points to.

The CircleCI flaky-retry step is unchanged. It greps the JUnit report for
`<flaky` and reads the test names from the report. Only two YAML comments
that described the old single-test scope change.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@teddyknox teddyknox self-assigned this Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Agent approval check

Head branch claude/keen-lehmann-9a3089 matches agent prefix claude/

Current head: aaa20457f4fd135502ccf039ebb65ad3910f3373
Human approvals: 2/2
Approvers: @joshklop, @sebastianst

teddyknox and others added 2 commits November 18, 2026 15:09
…seen

The override also covered
`test_lagoon_buffered_child_with_wrong_post_exec_block_number_is_invalid`,
which starts two nodes like the two tests that crashed but has no crash on
record. A retry for it stretches a stopgap that is an exception to the
no-retries policy. The override now covers a test only after the crash has
been seen on it.

That test keeps the fatal-signal handler. A crash there fails the job and
leaves the faulting stack, which is the evidence needed to add the test to
the override.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@teddyknox teddyknox changed the title rust,op-reth: restore the teardown-SIGSEGV retry and cover the two-node tests rust,op-reth: restore the teardown-SIGSEGV retry and cover the second test that crashed Nov 18, 2026
Keep only the change that restores the #20973 stopgap: the override filter
names `peers_negotiate_eth_71`, the name the test has had since #23046.

Take out the rest of this branch: the second test in the override, the
crash handler in the `invalid_post_exec` tests, and the comment edits in
`nextest.toml` and `rust-ci.yml`.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@teddyknox teddyknox changed the title rust,op-reth: restore the teardown-SIGSEGV retry and cover the second test that crashed rust: point the teardown-SIGSEGV retry at the renamed p2p test Nov 18, 2026
@teddyknox
teddyknox marked this pull request as ready for review November 18, 2026 20:35
@teddyknox
teddyknox requested a review from a team as a code owner November 18, 2026 20:35
@teddyknox
teddyknox enabled auto-merge November 18, 2026 20:52
@teddyknox
teddyknox added this pull request to the merge queue Nov 18, 2026
Merged via the queue into develop with commit 56e61d2 Nov 18, 2026
120 checks passed
@teddyknox
teddyknox deleted the claude/keen-lehmann-9a3089 branch November 18, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants