Skip to content

op-reth: carry --txpool.enforce-tracked-nonce from reth#28526 - #24327

Merged
joshklop merged 2 commits into
developfrom
joshklop/op-reth-enforce-tracked-nonce
Nov 20, 2026
Merged

joshklop merged 2 commits into
developfrom
joshklop/op-reth-enforce-tracked-nonce

Conversation

@joshklop

@joshklop joshklop commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Repins reth to the fork tag op-v2.7.0-2, so operators can pass --txpool.enforce-tracked-nonce (off by default). The flag turns on the pool's tracked-nonce guard, which the pinned reth already carries but no flag could enable.

Without the guard, a sequencer can hold a valid next-nonce transaction in its queued pool for minutes. The validator reads the sender's nonce outside the pool lock, so a transaction validated just before the block that mined its predecessor is committed sees the old nonce, looks like it has a nonce gap, and waits until the sender's account changes again. One 1 s-block chain hit this for about 3 in 17k transactions, 5–10 minutes each. The guard assumes nonces only move forward, so it is meant for sequencers. op-reth-premium turns it on for its subblocks sequencer in a follow-up.

On top of op-v2.7.0-1, the tag carries ethereum-optimism/reth#47, a straight cherry-pick of paradigmxyz/reth#28526, and ethereum-optimism/reth#48, which only fixes the fork's CI. op-reth needs no code change: it builds its pool from ctx.pool_config(). The 30 UPSTREAM-MIRROR tags advance to op-v2.7.0-2; neither fork commit touches code they cover. cargo update reth-chainspec also rewrites some lockfile dependency edges among versions already locked, as it does on an unchanged pin.

Part of #24321 (its downstream repin, release and rollout tasks stay open).

Reviews: rust-code-reviewer ran on the new test; I kept the test because #24321 asks for it. reth-update-reviewer found nothing blocking. It flagged the missing carried-patches row, which this PR now adds. It also noted the guard's reorg assumption: the flag is off by default, and op-reth-premium refuses it together with --engine.allow-unwind-canonical-header.

🤖 Generated with Claude Code

Pin the reth fork tag op-v2.7.0-2. On top of op-v2.7.0-1 it carries:

- ethereum-optimism/reth#47, a backport of paradigmxyz/reth#28526. It adds
  the `--txpool.enforce-tracked-nonce` flag for the pool guard that
  op-v2.7.0-1 already carries (paradigmxyz/reth#26981) but that no flag
  could turn on.
- ethereum-optimism/reth#48, which only fixes the fork's CI (lockfile and
  cargo-deny config).

The guard closes a race in which the pool queues a next-nonce transaction
validated just before the block that mined its predecessor was committed.
op-reth builds its pool from `ctx.pool_config()`, so the flag needs no
op-reth code. A test pins that it survives op-reth's CLI parsing and
`pool_config_overrides`. The CLI snapshot gains the flag, off by default.

Neither fork change touches code an UPSTREAM-MIRROR covers, so all 30
mirror tags advance from op-v2.7.0-1 to op-v2.7.0-2. `cargo update
reth-chainspec` also rewrites some dependency edges among versions already
locked; it does that on an unchanged pin too.

Part of #24321

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joshklop
joshklop requested a review from a team as a code owner November 20, 2026 21:36
@joshklop
joshklop enabled auto-merge November 20, 2026 21:42
bitwiseguy
bitwiseguy previously approved these changes Nov 20, 2026
…d reth patch

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joshklop
joshklop added this pull request to the merge queue Nov 20, 2026
Merged via the queue into develop with commit 65e8033 Nov 20, 2026
99 checks passed
@joshklop
joshklop deleted the joshklop/op-reth-enforce-tracked-nonce branch November 20, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-reth: Carry --txpool.enforce-tracked-nonce from reth#28526

2 participants