Repository navigation
op-reth: carry --txpool.enforce-tracked-nonce from reth#28526 - #24327
Merged
Merged
Conversation
Pin the reth fork tag op-v2.7.0-2. On top of op-v2.7.0-1 it carries: - ethereum-optimism/reth#47, a backport of paradigmxyz/reth#28526. It adds the `--txpool.enforce-tracked-nonce` flag for the pool guard that op-v2.7.0-1 already carries (paradigmxyz/reth#26981) but that no flag could turn on. - ethereum-optimism/reth#48, which only fixes the fork's CI (lockfile and cargo-deny config). The guard closes a race in which the pool queues a next-nonce transaction validated just before the block that mined its predecessor was committed. op-reth builds its pool from `ctx.pool_config()`, so the flag needs no op-reth code. A test pins that it survives op-reth's CLI parsing and `pool_config_overrides`. The CLI snapshot gains the flag, off by default. Neither fork change touches code an UPSTREAM-MIRROR covers, so all 30 mirror tags advance from op-v2.7.0-1 to op-v2.7.0-2. `cargo update reth-chainspec` also rewrites some dependency edges among versions already locked; it does that on an unchanged pin too. Part of #24321 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshklop
enabled auto-merge
November 20, 2026 21:42
bitwiseguy
previously approved these changes
Nov 20, 2026
…d reth patch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 tasks
bitwiseguy
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins reth to the fork tag
op-v2.7.0-2, so operators can pass--txpool.enforce-tracked-nonce(off by default). The flag turns on the pool's tracked-nonce guard, which the pinned reth already carries but no flag could enable.Without the guard, a sequencer can hold a valid next-nonce transaction in its queued pool for minutes. The validator reads the sender's nonce outside the pool lock, so a transaction validated just before the block that mined its predecessor is committed sees the old nonce, looks like it has a nonce gap, and waits until the sender's account changes again. One 1 s-block chain hit this for about 3 in 17k transactions, 5–10 minutes each. The guard assumes nonces only move forward, so it is meant for sequencers. op-reth-premium turns it on for its subblocks sequencer in a follow-up.
On top of
op-v2.7.0-1, the tag carries ethereum-optimism/reth#47, a straight cherry-pick of paradigmxyz/reth#28526, and ethereum-optimism/reth#48, which only fixes the fork's CI. op-reth needs no code change: it builds its pool fromctx.pool_config(). The 30UPSTREAM-MIRRORtags advance toop-v2.7.0-2; neither fork commit touches code they cover.cargo update reth-chainspecalso rewrites some lockfile dependency edges among versions already locked, as it does on an unchanged pin.Part of #24321 (its downstream repin, release and rollout tasks stay open).
Reviews:
rust-code-reviewerran on the new test; I kept the test because #24321 asks for it.reth-update-reviewerfound nothing blocking. It flagged the missing carried-patches row, which this PR now adds. It also noted the guard's reorg assumption: the flag is off by default, and op-reth-premium refuses it together with--engine.allow-unwind-canonical-header.🤖 Generated with Claude Code