Skip to content

ci: run cargo deny natively instead of through act - #12

Closed
sebastianst wants to merge 2 commits into
joshklop/v2.6.0-review-fixesfrom
seb/ci-native-cargo-deny
Closed

sebastianst wants to merge 2 commits into
joshklop/v2.6.0-review-fixesfrom
seb/ci-native-cargo-deny

Conversation

@sebastianst

@sebastianst sebastianst commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

act-lint-deny fails on every push and same-repo PR, including the current pin a2800024d4, whose CI commit is unchanged from 4553cf1cab. lint.yml's deny job calls tempoxyz/ci/.github/workflows/deny.yml@main, which now starts with tempoxyz's secure-runner. That action errors without a GitHub OIDC token unless the event is a fork pull request, and act never gets one.

  • Native check: the same cargo deny --all-features check all now runs in a plain CircleCI job (lint-deny), with a digest-pinned rust:1.95-bookworm image and a checksum-pinned cargo-deny 0.20.2, the version tempoxyz's vendored action uses. deny is removed from the act lint matrix. The job stays inside the reth-act workflow, which is the required status check.
  • Stop following tempoxyz main: CircleCI no longer runs whatever lands on tempoxyz/ci's main branch for this check.
  • Drift: a comment on the job says to diff lint.yml's deny: job and tempoxyz/ci's deny.yml against it whenever this CI patch is re-applied onto a new reth release.
  • Advisory fix: once the check actually runs, it fails on RUSTSEC-2026-0292 (imbl-sized-chunks 0.1.3, through test-fuzz). This cherry-picks upstream's fix, reth#27286, which bumps imbl and drops the obsolete bitmaps exception. The monorepo lock is already on imbl-sized-chunks 0.2.0.

Verified locally: circleci config validate passes, and the exact command exits 0 on this branch. It fails on RUSTSEC-2026-0292 without the cherry-pick.

When the CI patch is next replayed onto a reth release, the CI commit should be squashed into the maintenance commit. The cherry-pick drops out once the release contains reth#27286.

Based on joshklop/v2.6.0-review-fixes, the pin branch for the reth v2.6.0 update (ethereum-optimism/optimism#23046).

🤖 Co-created with Claude Opus 5.5

@sebastianst
sebastianst force-pushed the seb/ci-native-cargo-deny branch from 608443d to 33538e1 Compare October 1, 2026 13:31
@sebastianst
sebastianst changed the base branch from joshklop/optimism to seb/engine-fcu-fixes October 1, 2026 13:31
@sebastianst
sebastianst added this pull request to stack #14 October 1, 2026 13:33
decofe and others added 2 commits October 12, 2026 15:06
)

Co-authored-by: Sergei Shulepov <2205845+pepyakin@users.noreply.github.com>
(cherry picked from commit 2599319)
lint.yml's `deny` job calls tempoxyz/ci's reusable deny.yml, which now
starts with tempoxyz's secure-runner. That action requires a GitHub
OIDC token unless the event is a fork pull request, and act never
receives one, so the job failed on every push and same-repo PR.

Run the same `cargo deny --all-features check all` in a CircleCI job
with a digest-pinned Rust image and a checksum-pinned cargo-deny
release, and drop `deny` from the act lint matrix.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@joshklop

Copy link
Copy Markdown

Folded into #15, the rebuilt v2.6.0 pin for ethereum-optimism/optimism#23046. Its CI commit now includes the native cargo deny job from this PR, and the paradigmxyz#27286 imbl pick is in there too. Closing in favor of #15.

🤖 Generated with Claude Code

@joshklop joshklop closed this Oct 12, 2026
@sebastianst
sebastianst deleted the seb/ci-native-cargo-deny branch October 21, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants