Repository navigation
feat(payload): allow publishing payloads built outside a payload job - #16
Closed
sebastianst wants to merge 1 commit into
Closed
sebastianst wants to merge 1 commit into
sebastianst wants to merge 1 commit into
Conversation
Adds `PayloadBuilderHandle::publish_built_payload`, which broadcasts a payload to the payload service's subscribers as `Events::BuiltPayload`. The node inserts the executed block of every such event into the engine tree, so an Engine API extension that builds a payload itself can hand it over the same way a resolved payload job does, and `newPayload` of that block does not execute it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Not needed anymore since we chose ethereum-optimism/optimism#23454 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PayloadBuilderHandle::publish_built_payload, which broadcasts a payload built outside a payload job to the payload service's subscribers asEvents::BuiltPayload.The node inserts the executed block of every
Events::BuiltPayloadinto the engine tree (InsertExecutedBlock), which is what letsnewPayloadskip re-executing a block the node built itself. Only a resolved payload job could emit that event so far, so a payload built at the Engine API layer, e.g. an OP Stack derived payload built insideengine_forkchoiceUpdated, never reached the tree andnewPayloadexecuted it a second time.🤖 Co-created with Claude Opus 5.5