Repository navigation
fix(engine): return payload job start errors from forkchoiceUpdated - #19
Merged
Merged
Conversation
joshklop
force-pushed
the
joshklop/v2.6.0-pin
branch
3 times, most recently
from
October 16, 2026 17:46
e038904 to
8d359d0
Compare
sebastianst
force-pushed
the
seb/payload-job-start-errors
branch
from
October 16, 2026 17:52
86baaac to
367f538
Compare
sebastianst
force-pushed
the
seb/payload-job-start-errors
branch
from
October 19, 2026 11:13
ed9186a to
27aafb0
Compare
sebastianst
changed the base branch from
joshklop/v2.6.0-pin
to
joshklop/v2.6.0-pin-ci-fix
October 19, 2026 11:13
sebastianst
changed the base branch from
joshklop/v2.6.0-pin-ci-fix
to
op-v2.6.0
October 20, 2026 11:14
nonsense
self-requested a review
October 20, 2026 14:05
nonsense
approved these changes
Oct 20, 2026
When the payload job for forkchoiceUpdated attributes couldn't be started, PendingPayloadId dropped the PayloadBuilderError and answered -38003 (invalid payload attributes) for every failure, including failures of the node such as a provider error, a missing parent header or a dropped reply. OnForkChoiceUpdated now resolves to a BeaconForkChoiceUpdateError, and a job start failure becomes BeaconForkChoiceUpdateError::PayloadJob with the builder's error. A payload builder rejects the attributes with the new PayloadBuilderError::InvalidAttributes, which the engine API maps to -38003; every other job start failure maps to -32603. Both carry the error in data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve `PendingPayloadId` with `?` and the existing `RecvError` conversion instead of a three-arm match, and document that `InvalidAttributes` only rejects the attributes when returned at job start. Trim tests that repeat coverage: the internal-error loop keeps one case per real failure path (a missing parent, a dropped sender, a custom builder error), and the SSZ proxy drops its second `-38003` case, already pinned by the RPC mapping test and the existing invalid-attributes case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvcVspqLS7H3kZwfXSAoJy
sebastianst
force-pushed
the
seb/payload-job-start-errors
branch
from
October 20, 2026 14:12
27aafb0 to
7e4cc35
Compare
sebastianst
enabled auto-merge (squash)
October 20, 2026 14:14
sebastianst
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Oct 20, 2026
ethereum-optimism/reth#19 merged into op-v2.6.0 as 89e32ef290, tagged op-v2.6.0-1. It has the tree of the fork commit the reth crates were pinned to by rev, plus the fork's CI change #21, which only touches a workflow file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the
PayloadBuilderErrorwhen the payload job forengine_forkchoiceUpdatedattributes can't be started, and maps it to the right JSON-RPC error.Before,
PendingPayloadIddropped the error and resolved toForkchoiceUpdateError::UpdatedInvalidPayloadAttributes, so every job start failure reached the consensus client as-38003 Invalid payload attributeswithout a reason. That includes failures that have nothing to do with the attributes:BasicPayloadJobGenerator::new_payload_jobonly fails on a provider error or a missing parent header, and a payload service that drops the request did the same. A consensus client that acts on-38003, for example by discarding the attributes, then discards valid ones. This PR fixes that.OnForkChoiceUpdatedresolves toResult<ForkchoiceUpdated, BeaconForkChoiceUpdateError>. A job start failure becomes the newBeaconForkChoiceUpdateError::PayloadJob(PayloadBuilderError), a dropped replyPayloadJob(ChannelClosed).PayloadBuilderError::InvalidAttributeslets a payload builder reject the attributes, e.g. because a transaction they include can't be executed.PayloadJob(InvalidAttributes)maps to-38003, every otherPayloadJoberror to-32603, both with the error indata. Only the payload builder can tell that the attributes are at fault, so whatever it doesn't reject that way is a failure of the node and must not be reported as invalid attributes.Attributes rejected by the engine's own checks (version-specific fields, timestamp against the parent) still get
-38003as before. Like paradigmxyz#22374, which returns-32602for attribute structure errors, this gives a forkchoiceUpdated failure the code that matches its cause.Backport of paradigmxyz#28015, merged upstream as
186af6d36a(both PR commits; same content as the squash). The second commit's SSZ proxy test changes are dropped: that test has noPayloadJobcases on this base.A payload job generator or payload service that rejects attributes when the job starts must now return
PayloadBuilderError::InvalidAttributesto keep answering-38003; any other error now gets-32603.Breaking:
OnForkChoiceUpdated::Outputchanges toResult<ForkchoiceUpdated, BeaconForkChoiceUpdateError>(OnForkChoiceUpdatedResult), andBeaconForkChoiceUpdateErrorandPayloadBuilderErrorgain a variant.🤖 Co-created with Claude Opus 5.5