Skip to content

ci: fix fork validation for the v2.6.0 pin - #20

Closed
joshklop wants to merge 294 commits into
optimismfrom
joshklop/v2.6.0-pin-ci-fix
Closed

joshklop wants to merge 294 commits into
optimismfrom
joshklop/v2.6.0-pin-ci-fix

Conversation

@joshklop

@joshklop joshklop commented Oct 16, 2026 •

Copy link
Copy Markdown

Review-only candidate for the next force-push of optimism; do not merge this PR. The reviewed head is d9bd9875fe88dcc0183d78b187ce2ceab0c93e93, directly on top of the monorepo's published pin 8d359d0142719d4042eaf09fcbb7e4a1f89c37ac. Because optimism still points to the older release, the full PR diff also includes the reth update already merged in ethereum-optimism/optimism#23046. The incremental change from the published pin is only three files: 8d359d0...d9bd987.

The compact compatibility job reused base-revision libraries after act restored older source mtimes, causing a false missing-method error. A separate target directory forces the reader to build from the head sources while preserving the base-generated vectors. The valid_blocks fixture group receives a bounded ten-minute timeout matching the grouped general-state tests; previously it timed out at the default sixty seconds on all three attempts while the other 61 groups passed. The fork's rustls lock also advances to the patched release for RUSTSEC-2026-0346 through RUSTSEC-2026-0349; the consuming monorepo already resolves that release.

Review found no issues: all runtime sources are identical to the published pin, vectors remain outside the build directory, the rustls dependency requirements/features are unchanged, and the timeout override selects only the exact ef-tests::tests valid_blocks test while retaining all assertions and other timeout settings. YAML/TOML validation pass. All 29 CircleCI jobs and the aggregate check passed on this exact head. All 62 Ethereum state-test groups passed with none skipped; valid_blocks completed in 70.049 seconds, confirming the previous sixty-second cutoff was insufficient.

Downstream pin update: ethereum-optimism/optimism#23471. The original pin is preserved by annotated tag update-v2.6.0-df7168efb50b. After the monorepo pin update merges, move optimism directly to the reviewed head and tag it with the resulting monorepo commit hash.

mattsse and others added 30 commits August 19, 2026 12:14
…z#26752)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…yz#26750)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Co-authored-by: Emma Jamieson-Hoare <21029500+emmajam@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…xyz#26767)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
)

Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
…yz#26808)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…6810)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…6828)

Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Alexey Shekhirin <github@shekhirin.com>
sergey-melnychuk and others added 23 commits September 16, 2026 00:07
…radigmxyz#27261)

Co-authored-by: sergey-melnychuk <sergey-melnychuk@users.noreply.github.com>
)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…yz#27265)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…digmxyz#27266)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…yz#27275)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Pin that `OverlayStateProvider::storage_root` reads trie nodes through
the overlay when partial persistence leaves database storage-trie nodes
older than the persisted hashed storage. OP Stack consensus depends on
this: the Isthmus withdrawals root is the L2ToL1MessagePasser storage
root, computed through `storage_root` when building and validating
blocks.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…igmxyz#27247)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
(cherry picked from commit a120f00)
…igmxyz#27429)

Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
(cherry picked from commit 444e867)
Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
(cherry picked from commit 078d026)
…dAccounts (paradigmxyz#27252)

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Brian Picciano <me@mediocregopher.com>
(cherry picked from commit 695b4f1)
Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
Co-authored-by: Brian Picciano <me@mediocregopher.com>
(cherry picked from commit 5e309af)
)

Co-authored-by: Sergei Shulepov <2205845+pepyakin@users.noreply.github.com>
(cherry picked from commit 2599319)
Squash the fork CI support from 04e73b7 and push-event support from b0d194c into one replayable maintenance commit.

Preserve release action pins and advisory policy when resolving the replay. Select the book build job without entering Pages deployment. Refresh the standalone lockfile to patched h2 and rustls releases instead of suppressing RUSTSEC-2026-0258 and RUSTSEC-2026-0285; rustls requires the updated AWS-LC backend.

Run cargo deny natively instead of through act (folded in from c279f31): lint.yml's `deny` job calls tempoxyz/ci's reusable deny.yml, which starts with tempoxyz's secure-runner. That action requires a GitHub OIDC token unless the event is a fork pull request, and act never receives one, so the job failed on every push and same-repo PR. Run the same `cargo deny --all-features check all` in a CircleCI job with a digest-pinned Rust image and a checksum-pinned cargo-deny release, and drop `deny` from the act lint matrix.

Co-authored-by: Josh Klopfenstein <git@joshklop.com>
Co-authored-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Maintenance CI: Compare optimism push vectors against v2.6.0, retaining actual PR and merge-queue bases.:
Build the compact reader in a separate target directory so act cannot
reuse libraries compiled from the comparison base after restoring older
source mtimes.

Update the fork's rustls lock from 0.23.45 to 0.23.46 for
RUSTSEC-2026-0346 through RUSTSEC-2026-0349. The consuming Optimism
workspace already resolves 0.23.46. Preserve the published pin as parent.
@joshklop
joshklop changed the base branch from joshklop/v2.6.0-pin to optimism October 16, 2026 17:50
@joshklop
joshklop marked this pull request as draft October 16, 2026 17:56
valid_blocks runs the whole ValidBlocks fixture directory but inherits
the single-test sixty-second timeout. The CircleCI run terminated it at
that boundary on all three attempts while the other 61 groups passed.

Give only this exact ef-tests test the ten-minute budget already used by
grouped general-state fixtures. All assertions, retries, and other test
timeouts remain unchanged. A successful remote run must still prove it
finishes within the new bound.
@joshklop joshklop changed the title ci: isolate compact builds and refresh the rustls lock ci: fix fork validation for the v2.6.0 pin Oct 16, 2026
@joshklop joshklop closed this Oct 16, 2026
@sebastianst
sebastianst deleted the joshklop/v2.6.0-pin-ci-fix branch October 21, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.