Repository navigation
deps: backport compression security fixes to op-v2.6.0 - #27
Closed
einar-oplabs wants to merge 5 commits into
Closed
einar-oplabs wants to merge 5 commits into
einar-oplabs wants to merge 5 commits into
Conversation
Backport paradigmxyz#28158 and paradigmxyz/reth-core#74 while retaining the published compressor's 0.7 API and compression dictionaries. Carry upstream's crypto-bigint exception for elliptic-curve 0.13 and update compatible TLS/runtime patch releases flagged by the audit. Add an isolated old/new compression compatibility matrix and CI coverage.
Adapt upstream reth paradigmxyz#27687 to the release test harness. Keep genesis outside the conversion window and import the Prague payload only after both legacy sidecars have been checked. Wait for the pool's converted sidecar before checking the Osaka payload. Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Author
|
Dropped from ethereum-optimism/protocol-team#485; #26 targets op-v2.6.0 directly. Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports compatible compression security updates onto the existing Reth release line using the maintained reth-core backport. The compressor source and dictionaries stay unchanged; no compressor source is vendored. Explicit zstd consumers align with the patched dependency, and compatible TLS/runtime patch updates are included. The Rust 1.95 minimum is preserved.
Carries upstream’s documented
RUSTSEC-2026-0387exception: elliptic-curve 0.13 requires an unpatched crypto-bigint 0.5 release. This is an explicitly accepted advisory exception, not a fixed vulnerability. No other advisory is ignored. A fresh audit identified the newer libz-sys advisory; the lockfile now uses patchedlibz-sys 1.1.31.Local validation: full cargo-deny passes against the same frozen advisory database; the 36-case old/new compression matrix and strict Clippy pass on Rust 1.95. The matrix covers both frame directions, dictionary identity, buffer growth, and malformed streaming frames. Both wrappers share native zstd through Cargo. All 31 CI checks pass on
3ffdba2f, including cargo-deny, compression/compact compatibility, unit/integration/state/doc tests, Clippy, formatting, and the Rust 1.95 MSRV check.Security prerequisite for RPC PR #26, kept separate from its replay implementation for ethereum-optimism/protocol-team#485. The full crypto dependency migration is excluded.
Depends on ethereum-optimism/reth-core#1. The current source pin is a previously CI-validated commit. Replace the temporary reth-core revision with its validated merged maintenance-branch tag before landing security consumers; Cargo patches must be repeated in consuming workspace roots. No new tag is created by this CI refresh.