Use progressive list for payload attestation pool response - #635
Merged
nflaig merged 1 commit intoAug 17, 2026
Merged
Conversation
tersec
approved these changes
Aug 17, 2026
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Aug 17, 2026
`getPoolPayloadAttestations` may return aggregates for multiple block roots or slots and exceed the 4 payload attestations allowed in one block. Its SSZ codec reused `MAX_PAYLOAD_ATTESTATIONS`, so larger pool responses could not be decoded. Use the Gloas progressive `PayloadAttestations` type and cover JSON and SSZ responses with 5 entries see ethereum/beacon-APIs#635
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAX_PAYLOAD_ATTESTATIONSlimits attestations included in a block for one parent, but the pool response may contain attestations for multiple block roots or slots and exceed 4 entriesDescribe the SSZ response as
ProgressiveList[PayloadAttestation], matching the unbounded JSON response and the GloasPayloadAttestationstypeh/t to Caleb for finding this