feat(tests): EIP-8037 reject when calldata_floor > TX_MAX_GAS_LIMIT by chfast · Pull Request #2898 · ethereum/execution-specs

chfast · 2026-05-22T10:43:40Z

🗒️ Description

EIP-8037 requires max(intrinsic_regular, calldata_floor) <= TX_MAX_GAS_LIMIT. The existing tx.gas_limit < total_intrinsic check already covers the intrinsic-regular arm, so only the calldata_floor arm is observably untested.

Parametrize types 1 and 2 over floor_binds, intrinsic_binds, and neither_binds.

🔗 Related Issues or PRs

N/A.

✅ Checklist

All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
just static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

marioevz

The test looks solid, just some minor comments.

The base branch was changed.

marioevz · 2026-06-09T20:44:03Z

@chfast I changed the base because EIP-8037 is now merged to forks/amsterdam but git didn't take it so well. Could you rebase please?

EIP-8037 requires max(intrinsic_regular, calldata_floor) <= TX_MAX_GAS_LIMIT. The existing `tx.gas_limit < total_intrinsic` check already covers the intrinsic-regular arm, so only the calldata_floor arm is observably untested. Parametrize types 1 and 2 over floor_binds, intrinsic_binds, and neither_binds. evmone amsterdam/main without fd35d839 fails the floor_binds rows; geth bal-devnet-7 and EELS pass all.

codecov · 2026-06-10T07:21:17Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.00%. Comparing base (84e39e1) to head (f41c4b3).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Files with missing lines	Patch %	Lines
src/ethereum/forks/amsterdam/transactions.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           forks/amsterdam    #2898      +/-   ##
===================================================
- Coverage            90.53%   89.00%   -1.53%     
===================================================
  Files                  535      496      -39     
  Lines                32897    30100    -2797     
  Branches              3021     2725     -296     
===================================================
- Hits                 29782    26790    -2992     
- Misses                2596     2835     +239     
+ Partials               519      475      -44

Flag	Coverage Δ
unittests	`89.00% <50.00%> (-1.53%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

spencer-tb

Nice test additions! I don't think these fully hit the correct checks in EELS yet.

EELS validates intrinsic > tx.gas, floor > tx.gas in that order and then the two 8037 checks: intrinsic.regular > TX_MAX_GAS_LIMIT, intrinsic.calldata_floor > TX_MAX_GAS_LIMIT. With the tx gas_limit = cap + 1 both tx cases are rejected by the first 2 checks that we had originally.

I attached a suggestion below to target the intrinsic.regular > TX_MAX_GAS_LIMIT, intrinsic.calldata_floor > TX_MAX_GAS_LIMIT checks respectively. Let me know if it makes sense!

Additionally I think we could have a different exception type for these cases to distinguish the difference. The latter can be a follow up or feel free if it makes sense, would require an EELS spec change.

spencer-tb · 2026-06-10T13:06:48Z

+    if scenario == "floor_binds":
+        data = b"\x01" * ((cap - gas_costs.TX_BASE) // floor_per_byte + 1)
+        access_list = []
+    elif scenario == "intrinsic_binds":
+        data = b""
+        n = (cap - gas_costs.TX_BASE) // gas_costs.TX_ACCESS_LIST_ADDRESS + 1
+        access_list = [
+            AccessList(address=Address(i + 1), storage_keys=[])
+            for i in range(n)
+        ]


Suggested change

if scenario == "floor_binds":

data = b"\x01" * ((cap - gas_costs.TX_BASE) // floor_per_byte + 1)

access_list = []

elif scenario == "intrinsic_binds":

data = b""

n = (cap - gas_costs.TX_BASE) // gas_costs.TX_ACCESS_LIST_ADDRESS + 1

access_list = [

AccessList(address=Address(i + 1), storage_keys=[])

for i in range(n)

]

gas_limit = cap + 1

if scenario == "floor_binds":

data = b"\x01" * ((cap - gas_costs.TX_BASE) // floor_per_byte + 1)

access_list = []

gas_limit = fork.transaction_data_floor_cost_calculator()(

data=data, access_list=access_list

)

elif scenario == "intrinsic_binds":

data = b""

n = (cap - gas_costs.TX_BASE) // gas_costs.TX_ACCESS_LIST_ADDRESS + 1

access_list = [

AccessList(address=Address(i + 1), storage_keys=[])

for i in range(n)

]

gas_limit = fork.transaction_intrinsic_cost_calculator()(

calldata=data, access_list=access_list

)

spencer-tb · 2026-06-10T13:09:08Z

+    [
+        pytest.param(
+            "floor_binds",
+            TransactionException.INTRINSIC_GAS_TOO_LOW,


Suggested change

TransactionException.INTRINSIC_GAS_TOO_LOW,

TransactionException.FLOOR_GAS_EXCEEDS_MAXIMUM,

spencer-tb · 2026-06-10T13:09:19Z

+        ),
+        pytest.param(
+            "intrinsic_binds",
+            TransactionException.INTRINSIC_GAS_TOO_LOW,


Suggested change

TransactionException.INTRINSIC_GAS_TOO_LOW,

TransactionException.INTRINSIC_GAS_COST_EXCEEDS_MAXIMUM,

… over cap Per review: EELS raised a single InsufficientTransactionGasError for both `intrinsic.regular > TX_MAX_GAS_LIMIT` and `intrinsic.calldata_floor > TX_MAX_GAS_LIMIT`, conflating the EIP-8037/7825 cap rule with the generic gas-too-low check. Add distinct exceptions: - EELS amsterdam: IntrinsicGasCostExceedsMaximumError, FloorGasExceedsMaximumError; validate_transaction raises them. - Framework: TransactionException.INTRINSIC_GAS_COST_EXCEEDS_MAXIMUM, FLOOR_GAS_EXCEEDS_MAXIMUM, mapped in the execution-specs CLI. - test_intrinsic_or_floor_cap_at_validation: expect the distinct errors and size gas_limit to the exact floor/intrinsic cost so the rejection is pinned to the cap rule, not gas_limit < intrinsic.

spencer-tb · 2026-06-10T14:52:43Z

Thanks, moving this to #2915 as will have spec change! :)

edg-l mentioned this pull request May 22, 2026

tracking: glamsterdam-devnet-6 alignment lambdaclass/ethrex#6583

Open

This was referenced May 26, 2026

Test Release Tracker: bal-devnet@v7.3.0 #2912

Closed

Test Release Tracker: glamsterdam-devnet@v7.0.0 #2915

Open

marioevz self-requested a review June 9, 2026 20:26

marioevz previously approved these changes Jun 9, 2026

View reviewed changes

marioevz changed the base branch from devnets/bal/7 to forks/amsterdam June 9, 2026 20:42

marioevz mentioned this pull request Jun 9, 2026

feat(tests): EIP-8037 unmask intrinsic-cap transaction-validity checks #2956

Merged

7 tasks

chfast force-pushed the feat/eip-8037-intrinsic-cap-at-validation branch from c83f348 to cbf96d8 Compare June 10, 2026 07:11

chfast requested a review from marioevz June 10, 2026 07:12

spencer-tb reviewed Jun 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tests): EIP-8037 reject when calldata_floor > TX_MAX_GAS_LIMIT#2898

feat(tests): EIP-8037 reject when calldata_floor > TX_MAX_GAS_LIMIT#2898
chfast wants to merge 2 commits into
ethereum:forks/amsterdamfrom
chfast:feat/eip-8037-intrinsic-cap-at-validation

chfast commented May 22, 2026 •

edited

Loading

Uh oh!

marioevz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz commented Jun 9, 2026

Uh oh!

codecov Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

spencer-tb left a comment

Uh oh!

spencer-tb Jun 10, 2026

Uh oh!

spencer-tb Jun 10, 2026 •

edited

Loading

Uh oh!

spencer-tb Jun 10, 2026 •

edited

Loading

Uh oh!

spencer-tb commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	TransactionException.INTRINSIC_GAS_TOO_LOW,
	TransactionException.FLOOR_GAS_EXCEEDS_MAXIMUM,

	TransactionException.INTRINSIC_GAS_TOO_LOW,
	TransactionException.INTRINSIC_GAS_COST_EXCEEDS_MAXIMUM,

Conversation

chfast commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz commented Jun 9, 2026

Uh oh!

codecov Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

spencer-tb left a comment

Choose a reason for hiding this comment

Uh oh!

spencer-tb Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

spencer-tb Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spencer-tb Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spencer-tb commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chfast commented May 22, 2026 •

edited

Loading

codecov Bot commented Jun 10, 2026 •

edited

Loading

spencer-tb Jun 10, 2026 •

edited

Loading

spencer-tb Jun 10, 2026 •

edited

Loading