refactor(test-benchmark): update test_account_access, add keccak256 overhead scenario#2947
Draft
LouisTsai-Csie wants to merge 13 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2947 +/- ##
================================================
Coverage 90.53% 90.53%
================================================
Files 535 535
Lines 32893 32895 +2
Branches 3021 3022 +1
================================================
+ Hits 29780 29782 +2
Misses 2595 2595
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9561e54 to
b5832cd
Compare
Collaborator
Author
|
I've rebased the PR and updated the description, please review and integrate contract deployment into state-actor. cc @jochem-brouwer |
b5832cd to
2e62fa1
Compare
22b4ee8 to
be28fa8
Compare
99ae842 to
6ef4781
Compare
6ef4781 to
4f7cf29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The original
test_account_accesstargets contracts created by theBittrexcontroller factory. This requiresCREATEaddress calculations, introducing significant overhead and it is hard to precisely control overEXPandKECCAK256inputs.We introduced several changes in this PR:
test_account_accessfromtest_single_opcode.pytotest_account_query.pyEXISTING_CONTRACTparametrization, addingEXISTING_CONTRACT_MINIMAL,EXISTING_CONTRACT_SAMEandEXISTING_CONTRACT_DIFFparametrization.deployed contract and initcode for each parametrization:
EXISTING_CONTRACT_MINIMAL
initcode:
RETURN(PUSH1(0), PUSH1(1))deployed code:
STOPEXISTING_CONTRACT_SAME
initcode:
deployed code:
STOP JUMPDEST JUMPDEST ... ... ... JUMPDEST (fill until max code size)
EXISTING_CONTRACT_DIFF
initcode:
deployed code:
STOP STOP ... STOP ADDRESS JUMPDEST ... ... ... JUMPDEST (fill until max code size)
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture