fix(tooling): include namespace packages in coverage reports#2982
Open
danceratopz wants to merge 1 commit into
Open
fix(tooling): include namespace packages in coverage reports#2982danceratopz wants to merge 1 commit into
danceratopz wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2982 +/- ##
===================================================
- Coverage 90.52% 81.29% -9.24%
===================================================
Files 535 620 +85
Lines 32893 36635 +3742
Branches 3021 3311 +290
===================================================
+ Hits 29778 29782 +4
- Misses 2596 6335 +3739
+ Partials 519 518 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Enable coverage.py's
include_namespace_packagesoption so that never-imported modules under theethereum.forksnamespace package count towards the coverage denominator (at 0%); this gives all coverage uploads the same denominator and explains the apparent coverage drop seen in #2975, wherefill-only reports silently excluded the never-importedspurious_dragonandtangerine_whistlefork trees.🔗 Related Issues or PRs
Related to #2975.
✅ Checklist
just statictype(scope):.Cute Animal Picture