Support pending PR EIP pages#334
Merged
Merged
Conversation
✅ Deploy Preview for eth-forkcast ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dionysuzx
changed the title
|
Reviewed for correctness and architecture/style. I don't see any blocking issues. Validation run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pending PR-backed EIPs are already indexed in Forkcast and can have local analysis content, so their
/eips/:idroutes should remain Forkcast pages instead of redirecting to GitHub.This removes the generated pending-EIP redirects, includes pending EIPs in the static EIP route list, and drops the client-side pending-PR redirect from the EIP page. When a mirrored spec markdown file is not available yet, the Specification tab still links to the GitHub PR and labels that link as a pull request.
Root Cause
PR-backed EIP records carry
pendingPullRequest, and the route layer treated that field as meaning the record was external-only. EIP-8282 has Forkcast content but still references an open upstream EIPs PR, so/eips/8282/redirected out to GitHub.Validation
npm run buildhttp://127.0.0.1:4321/eips/8282/stayed on the Forkcast route, rendered the EIP-8282 page, and kept the specification link pointed athttps://github.com/ethereum/EIPs/pull/11760.