This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Add typed transactions - EIP 2718 - Berlin - #1978
Merged
Merged
Conversation
carver
force-pushed
the
eip-2718-typed-txns
branch
from
February 25, 2021 17:38
7935801 to
54a828c
Compare
carver
marked this pull request as ready for review
February 25, 2021 17:41
Contributor
Author
|
Ok, I think this has the basic shape that we want. I won't ask for a final merge review yet, but it's far enough along if anyone wants to give architectural feedback, or just follow what's happening. cc @kclowes @marcgarreau |
carver
added a commit
to carver/py-evm
that referenced
this pull request
Feb 25, 2021
Contributor
Author
|
Ok, now ready for a proper review. Are you folks up for a call tomorrow morning to look over it together? I know you're new to the repo, so hopefully we'll catch anything funky as I try to explain out loud what's going on. :) |
Contributor
|
@carver will give it a look now, but would love to talk through it in the morning - thanks :) |
Contributor
|
@carver yep, tomorrow morning would be great! |
carver
commented
Feb 26, 2021
| rlp.decode(encoded, sedes=sedes) | ||
| else: | ||
| # Check that the given transaction encodes to the start encoding | ||
| expected_txn = BerlinLegacyTransaction(**expected) |
Contributor
Author
There was a problem hiding this comment.
Use the new_transaction() API.
Suggested change
| expected_txn = BerlinLegacyTransaction(**expected) | |
| expected_txn = sedes.new_transaction(**expected) |
carver
commented
Feb 26, 2021
| ) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize( | |
| @pytest.mark.parametrize('vm_class', [BerlinVM]) | |
| @pytest.mark.parametrize( |
|
|
||
| # TODO: subclass rlp.sedes.dynamic.DynamicSerializable, when it's released | ||
| # See the example in pyrlp:tests/core/test_dynamic_entries.py | ||
| class BerlinTransaction(TransactionBuilderAPI): |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| class BerlinTransaction(TransactionBuilderAPI): | |
| class BerlinTransactionBuilder(TransactionBuilderAPI): |
| + INVALID_TRANSACTION_TYPES | ||
| ) | ||
| def test_transaction_decode(encoded, expected): | ||
| sedes = BerlinVM.get_transaction_class() |
Contributor
Author
There was a problem hiding this comment.
Refactor:
Suggested change
| sedes = BerlinVM.get_transaction_class() | |
| sedes = BerlinVM.get_transaction_builder() |
Contributor
Author
|
Handled all the notes taken during review. |
- Refactor to split the responsibility for encode/decode and core transaction API - Test that legacy transactions still work in Berlin - Test invalid vs unrecognized transaction types Invalid types are disallowed by EIP-2718, unrecognized ones are just not specified yet. (Although one will be soon, in EIP-2930)
carver
force-pushed
the
eip-2718-typed-txns
branch
from
February 26, 2021 20:25
9f7cb72 to
8ac8e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #1973
How was it fixed?
Uses the basic structure from ApeWorX/pyrlp#131 to enable dynamic encodings. It kicks the can down the road a bit to #1975 for actually supported any specific typed transactions, since they aren't defined until then.
Had to split the transaction responsibility up a bit: isolated a transaction builder/serializer from the actual transaction API. It causes some code churn, but not quite as much as I feared.
To-Do
Cute Animal Picture