Adding Glamsterdam changes#28
Draft
usmansaleem wants to merge 3 commits into
Draft
Conversation
Adds four new signing types for the Glamsterdam (ePBS) fork: - EXECUTION_PAYLOAD_BID — signed by builders (DOMAIN_BEACON_BUILDER, 0x0B000000) - EXECUTION_PAYLOAD_ENVELOPE — signed by builders (DOMAIN_BEACON_BUILDER) - PAYLOAD_ATTESTATION_MESSAGE — signed by PTC attesters (DOMAIN_PTC_ATTESTER, 0x0C000000) - PROPOSER_PREFERENCES — signed by proposers (DOMAIN_PROPOSER_PREFERENCES, 0x0D000000) Adds matching data schemas (ExecutionPayloadBid, ExecutionPayloadEnvelope, ExecutionPayloadGloas, PayloadAttestationData, ProposerPreferences) and wires the new wrappers into the sign endpoint's oneOf + discriminator mapping. Tracks ethereum#23.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four new signing types for the upcoming Glamsterdam (ePBS) fork. These are client-agnostic spec additions intended for any consensus client (Teku, Lighthouse, Lodestar, Nimbus, Prysm) interacting with a remote signer.
EXECUTION_PAYLOAD_BIDDOMAIN_BEACON_BUILDER(0x0B000000)EXECUTION_PAYLOAD_ENVELOPEDOMAIN_BEACON_BUILDER(0x0B000000)PAYLOAD_ATTESTATION_MESSAGEDOMAIN_PTC_ATTESTER(0x0C000000)PROPOSER_PREFERENCESDOMAIN_PROPOSER_PREFERENCES(0x0D000000)Schema additions
ExecutionPayloadBidSigning/ExecutionPayloadBid(12 fields, incl.execution_requests_root)ExecutionPayloadEnvelopeSigning/ExecutionPayloadEnvelope(4 fields:payload,execution_requests,builder_index,beacon_block_root)ExecutionPayloadGloasdata schema (Deneb shape +block_access_listandslot_number; the slot moved from envelope into the payload in ePBS)PayloadAttestationMessageSigning/PayloadAttestationData(4 fields)ProposerPreferencesSigning/ProposerPreferences(4 fields)/signendpoint'soneOf+ discriminator mapping is extended with the four new types.Tracks #23.
Field shapes mirror the current Teku
develop(post-26.4.0) consensus types — primarily because Teku is the first client implementing the GLOAS data structures end-to-end. Other client teams should review and push back on:ExecutionPayloadEnvelopeshape post-slot-relocation.PROPOSER_PREFERENCESbelongs in the spec at this layer or is something proposers handle locally.Spec is published as draft and will be revised once cross-client consensus is reached.
Test plan
oneOfdiscriminator consistency)