Conversation
…nt of accumulated DIP
fix: call _updateRewards during claimRewards to transfer correct amount of accumulated DIP
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Description
Calling
claimRewards()beforeunstake()incorrectly sends 0 DIP rewards becauseinfo.rewardBalancewas not being updated with newly accrued rewards before transferring. Meanwhile,_decreaseRewards()updatesinfo.updatedAtto the current block, which essentially resets the reward calculations, wiping out any accumulated rewards the user had.Changes
_updateRewards(info)inside theclaimRewards(NftId stakeId)function inStakingV01.sol. This ensures thatinfo.rewardBalanceaccurately reflects the accrued rewards before_claimRewards(user, info)determines the payout amount.StakingV01.solwith the correct behavior already present inStakingV02.sol.This PR was created with AI assistance.