Conversation
1 task
fix: update rewards before direct claim
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
StakingV01.claimRewardspaid only the storedrewardBalance. If a staker calledclaimRewards()before any unstake or owner reward update, accrued rewards were not first materialized into the stake info, so the claim could emit/pay0even thoughcalculateRewardsIncrement()was positive.This updates rewards before claiming in the base V1 implementation, matching the later V2 behavior and the expectation that a direct claim pays currently accrued rewards.
Also adds a regression test against the V1 staking fixture that:
rewardBalanceis still0before claimclaimRewards()without unstaking firstVerification performed locally:
git diff --checkpython3 -m py_compile tests/test_staking_unstake_claim_rewards.pynpx --yes solhint@3.6.2 contracts/staking/StakingV01.sol(0 errors; existing custom-error warnings only)I could not run
brownie testlocally because Brownie is not installed on this machine,pip install eth-brownieis blocked by its pinnedPyYAML==5.4.1build on the local macOS/Python setup, and Docker is installed but the daemon is not running for the repository devcontainer.