Repository navigation
fix(chainfold): reject cursorless snapshots that carry a ring - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the mismatch error message to accurately describe cursorless snapshots.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Rejects cursorless snapshots containing ring entries to preserve cursor/ring consistency during decoding.
Changes:
- Enforces cursor/ring presence consistency.
- Adds regression coverage for malformed snapshots.
| File | Description |
|---|---|
crates/chainfold/src/snapshot.rs |
Updates snapshot validation and adds regression coverage; error wording should also cover cursorless cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
oskarth
removed their request for review
September 29, 2026 03:17
cygnusv
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #49
decode_snapshotvalidatedring.last() == cursor.blockonly forSomecursors. Acursorless envelope with ring entries decoded into an engine with
cursor = Noneand anon-empty ring, which no engine reaches. The first batch then set the cursor without
pushing its block, and every later batch failed with
CursorBlockUnobserved.