Repository navigation
test(rotortree): poll for the checkpoint meta file instead of racing - #58
Merged
Merged
Conversation
wait_for_checkpoint only sees a checkpoint that finishes after the call. The inserts start the background checkpoint, so it can finish first and the wait times out. Poll for data/checkpoint.meta, which write_meta renames into place, so the tests no longer depend on timing.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
rymnc
enabled auto-merge (squash)
October 27, 2026 08:53
rymnc
disabled auto-merge
October 27, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkpoint_every_n_entriesflaked on #57:wait_for_checkpointonly sees a checkpoint that finishes after the call, and the one the inserts start can finish first, so the wait times out.Both auto-checkpoint tests now poll for
data/checkpoint.meta(written by atomic rename) instead. Test-only; no library change.