-
Notifications
You must be signed in to change notification settings - Fork 84
[ENG-2185] Adding Consent #7174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JadeCara
wants to merge
10
commits into
ENG-2185-remove-unused-cols
Choose a base branch
from
ENG-2185-add-consent-to-manual-tasks
base: ENG-2185-remove-unused-cols
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[ENG-2185] Adding Consent #7174
JadeCara
wants to merge
10
commits into
ENG-2185-remove-unused-cols
from
ENG-2185-add-consent-to-manual-tasks
+442
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ENG-2185-remove-unused-cols #7174 +/- ##
===============================================================
- Coverage 84.98% 82.90% -2.08%
===============================================================
Files 535 535
Lines 35257 35280 +23
Branches 4106 4109 +3
===============================================================
- Hits 29962 29249 -713
- Misses 4370 5130 +760
+ Partials 925 901 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
18 tasks
JadeCara
commented
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2185
Description Of Changes
🎯 Add Manual Tasks for Consent
This PR updates the Manual Tasks to use the Action Type of the associated Policy thus adding consent. It also allows conditions and users to be assigned to a full task (all things) or a specific field (text, attachment or checkbox). It is a clean up based on the first few rounds of customer use and learning actual usage patterns.
Note the consent task is being added here, but is tricky to test before it is added to the consent graph which happens in #7175 the lines that are not tested here are tested in that PR.
Past PRs:
This PR:
Future PRs:
Code Changes
.fides/db_dataset.yml- removedManualTaskLogtablesrc/fides/api/alembic/migrations/versions/remove the manual task table.src/fides/api/db/base.py- removed un used columnssrc/fides/api/models/digest/conditional_dependencies.pyremoved digest un-used colssrc/fides/api/models/manual_task/conditional_dependency.pyremoved manual task un-used colsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works